From: | "Joe Conway" <joe(at)conway-family(dot)com> |
---|---|
To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: Fw: Isn't pg_statistic a security hole - Solution Proposal |
Date: | 2001-06-03 03:22:44 |
Message-ID: | 013c01c0ebdc$75214120$0705a8c0@jecw2k1 |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Thanks for the detailed feedback, Tom. I really appreciate the pointers on
my style and otherwise. Attached is my next attempt. To summarize the
changes:
- changed usesysid back to Oid. I noticed that the Acl functions all treated
usesysid as an Oid anyway.
- changed function names to has_user_privilege_name_name,
has_user_privilege_name_id, etc
- trimmed down test script, added variety (some privs granted, not all), and
added bad input cases (this already paid off -- see below)
- replaced has_table_privilege(int usesysid, char *relname, char *priv_type)
with
AclMode convert_priv_string (text * priv_type_text)
- changed
if (result == 1) {
PG_RETURN_BOOL(FALSE);
. . .
to
if (result == ACLCHECK_OK) {
PG_RETURN_BOOL(TRUE);
. . .
- removed #define PRIV_INSERT "INSERT\0", etc from acl.h
One item of note -- while pg_aclcheck *does* validate relname for
non-superusers, it *does not* bother for superusers. Therefore I left the
relname check in the has_table_privilege_*_name() functions. Also note that
I skipped has_priv_r3.diff -- that one helped find the superuser/relname
issue.
I hope this version passes muster ;-)
-- Joe
Attachment | Content-Type | Size |
---|---|---|
has_priv_r4.diff | application/octet-stream | 12.0 KB |
test_has_table_priv.sql | application/octet-stream | 6.2 KB |
test_has_table_priv.out | application/octet-stream | 8.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2001-06-03 15:18:20 | Re: [PATCHES] Fw: Isn't pg_statistic a security hole - Solution Proposal |
Previous Message | Gavin Sherry | 2001-06-03 02:10:09 | Re: Full text searching, anyone interested? |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2001-06-03 15:18:20 | Re: [PATCHES] Fw: Isn't pg_statistic a security hole - Solution Proposal |
Previous Message | Tom Lane | 2001-06-02 23:26:12 | Re: Fw: Isn't pg_statistic a security hole - Solution Proposal |