Skip site navigation (1) Skip section navigation (2)

Re: win32mak_patch

From: "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>
To: "Magnus Hagander" <magnus(at)hagander(dot)net>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <pgsql-patches(at)postgresql(dot)org>
Subject: Re: win32mak_patch
Date: 2008-04-29 14:02:31
Message-ID: 00af01c8aa01$aae93ac0$0d01a8c0@IBMC9A0F63B40D (view raw or flat)
Thread:
Lists: pgsql-patches
Hi Magnus.

----- Original Message ----- 
From: "Magnus Hagander" <magnus(at)hagander(dot)net>


>> Um, win32.mak of libpq needed to add dirmod.c --
>> libpq.lib(fe-connect.obj) : error LNK2001: (snip-sjis message) 
>> "_pgwin32_safestat"
>> 
>> Then, Is containing in libpq wrong? I'm confused for a while...
> 
> Yes, you are missing something :-)

Ahh Sure, I had missed discussion of this improvement.
Then, It seems that win32.mak has been forgotten. 

> 
> The patch for win32.mak I'm happy to apply, it looks fine.

Yeah, Anyway I think that the equipment is required. 

> 
> The patch for exports.txt does not look fine.

About it, I do not have firm belief yet. However, It does not put in there.

> 
> Can you confirm that you can build things properly *with* the patch to 
> win32.mak but *without* the patch to exports.txt?

http://winpg.jp/~saito/pg_work/WIN32_BUILD_INF/psql_win32_n.mak
I checked the build without correction of exports.txt. 

> 
> Also, I assume this needs to be backpatched?

Yes, Since you have already done, I think that it is required. 
Thanks!

Regards,
Hiroshi Saito

In response to

pgsql-patches by date

Next:From: Alvaro HerreraDate: 2008-04-29 14:06:28
Subject: Re: [HACKERS] Proposed patch - psql wraps at window width
Previous:From: Magnus HaganderDate: 2008-04-29 12:53:34
Subject: Re: [HACKERS] [DOCS] pg_total_relation_size() and CHECKPOINT

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group