Skip site navigation (1) Skip section navigation (2)

Re: pg_dump.options.diff

From: "Serguei Mokhov" <mokhov(at)cs(dot)concordia(dot)ca>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Manfred Koizar" <mkoi-pg(at)aon(dot)at>,"PostgreSQL Hackers" <pgsql-hackers(at)postgresql(dot)org>,"Peter Eisentraut" <peter_e(at)gmx(dot)net>,"PostgreSQL Patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: pg_dump.options.diff
Date: 2003-01-02 22:51:55
Message-ID: 005701c2b2b1$8e923fe0$0301a8c0@gunnymede.lan (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
----- Original Message ----- 
From: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Sent: January 02, 2003 3:20 PM

> > #if defined(HAVE_GETOPT_LONG)
> > #define xo(long,short,desc)  printf("%s %s\n", long, desc)
> > #else
> > #define xo(long,short,desc)  printf("%s %s\n", short, desc)
> > #endif
> 
> > seems relatively generic, so it could be used by more than one tool.
> 
> But there's no good place to put it.  I'd say just stick it into each
> tool; it's no worse than repeating the existence of a "usage()"
> subroutine in each tool.

It ended up being in dumputils.h

Attached a patch for pg_dump(all) and pg_restore eliminating dupes
in option descriptions as per above xo "technology".

Please review and apply if there are no too many objections.

thank you,
-s

Attachment: pg_dump.options2.diff
Description: application/octet-stream (27.6 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Peter EisentrautDate: 2003-01-02 23:07:52
Subject: Re: PostgreSQL Password Cracker
Previous:From: Bruce MomjianDate: 2003-01-02 22:31:10
Subject: Re: Bug in pg_get_constraintdef (for deferrable constraints)

pgsql-patches by date

Next:From: Nic FerrierDate: 2003-01-02 22:57:54
Subject: Re: [PATCHES] Fwd: Patch for streaming resultsets
Previous:From: Tom LaneDate: 2003-01-02 20:20:35
Subject: Re: pg_dump.options.diff

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group