Skip site navigation (1) Skip section navigation (2)

PyGreSQL inserttable patch

From: "Christoph Zwerschke" <zwerschke(at)zuv(dot)uni-heidelberg(dot)de>
To: <pgsql-patches(at)postgresql(dot)org>
Subject: PyGreSQL inserttable patch
Date: 2002-11-27 09:15:51
Message-ID: 002901c295f5$953bde10$271f11ac@zwerschke (view raw or flat)
Thread:
Lists: pgsql-patches
PyGreSQL inserttable patch
=====================

I suggested an improvement of the inserttable in the PyGreSQL interface
already in January, but seemingly it was never implemented. I was told this
is the right place to get patches in for PyGreSQL, so I'm reposting my patch
here.

I consider the inserttable methode essential in populating the database
because of its benefits in performance compared to insert, so I think this
patch is quite essential. The attachment is an improved version of the
corresponding pg_inserttable function in pgmodule.c, which fixes the
following problems:

* The function raised exceptions because PyList_GetItem was used beyond the
size of the list. This was checked by comparing the result with NULL, but
the exception was not cleaned up, which could result in mysterious errors in
the following Python code. Instead of clearing the exception using
PyErr_Clear or something like that, I avoided throwing the exception at all
by at first requesting the size of the list. Using this opportunity, I also
checked the uniformity of the size of the rows passed in the lists/tuples.
The function also accepts (and silently ignores) empty lists and sublists.
* Python "None" values are now accepted and properly converted to PostgreSQL
NULL values
* The function now generates an error message in case of a line buffer
overflow
* It copes with tabulators, newlines and backslashes in strings now
* Rewrote the buffer filling code which should now run faster by avoiding
unnecessary string copy operations forth and back

[Side Mark: I think the following should be added to the to do list: "Write
an option for inserttable which uses 'copy binary from' instead of 'copy
from.'" This could speed up things considerably. In particular, numbers
would not be needed to be converted to strings forth and back. This is a
pretty difficult and laborious task and I can't do it. However, it should be
annotated as a possible 'to do'.]

Christoph Zwerschke
Zentrale Universitaetsverwaltung Heidelberg

Attachment: pg_inserttable.c
Description: application/octet-stream (4.2 KB)

Responses

pgsql-patches by date

Next:From: Neil ConwayDate: 2002-11-27 22:15:18
Subject: fix memory leaks in pg_dump
Previous:From: Larry RosenmanDate: 2002-11-27 00:51:38
Subject: Re: Resultmap for FreeBSD 4.7

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group