Skip site navigation (1) Skip section navigation (2)

RE: Important 7.0.* fix to ensure buffers are released

From: "Hiroshi Inoue" <Inoue(at)tpf(dot)co(dot)jp>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <t-ishii(at)sra(dot)co(dot)jp>
Cc: <pgsql-patches(at)postgreSQL(dot)org>
Subject: RE: Important 7.0.* fix to ensure buffers are released
Date: 2000-09-05 08:51:15
Message-ID: 001701c01716$733beb80$2801007e@tpf.co.jp (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
> -----Original Message-----
> From: Tom Lane
> 
> t-ishii(at)sra(dot)co(dot)jp writes:
> > Interesting thing is that 6.5.x does not have the problem. Is it new
> > one for 7.0.x?
> 
> I think the bug has been there for a long time.  It is easier to see

One of the reason why we see the bug often in 7.0 seems to be
the following change which was applied to temprel.c before 7.0.
remove_all_temp_relations() always called AbortOutAnyTransaction()
before the change. remove_all_temp_relations() has been called from
shmem_exit() and accidentally(I don't think it had been intensional)
proc_exit() always called AbortOutAnyTransaction().

@@ -79,6 +79,9 @@
 	List	   *l,
 			   *next;
 
+	if (temp_rels == NIL)
+		return;
+
 	AbortOutOfAnyTransaction();
 	StartTransactionCommand();
 

Regards.

Hiroshi Inoue

In response to

Responses

pgsql-hackers by date

Next:From: Finn KettnerDate: 2000-09-05 13:56:36
Subject: Visual Studio 6 project/workspace files
Previous:From: ChrisDate: 2000-09-04 22:51:34
Subject: Re: OO inheritance implementation

pgsql-patches by date

Next:From: Tom LaneDate: 2000-09-05 13:57:01
Subject: Re: Important 7.0.* fix to ensure buffers are released
Previous:From: t-ishiiDate: 2000-09-04 11:29:36
Subject: Re: Re: [PATCHES] Important 7.0.* fix to ensure buffers are released

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group