Re: "make check" improvement for cygwin

From: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
To: "PG Patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: "make check" improvement for cygwin
Date: 2003-10-28 01:20:44
Message-ID: 001101c39cf1$b5f17ee0$6401a8c0@DUNSLANE
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


----- Original Message -----
From: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
Cc: "PG Patches" <pgsql-patches(at)postgresql(dot)org>
Sent: Monday, October 27, 2003 7:41 PM
Subject: Re: [PATCHES] "make check" improvement for cygwin

> "Andrew Dunstan" <andrew(at)dunslane(dot)net> writes:
> > The attached patch limits parallelism for "make check" on cygwin to 10 -
me=
> > aning that at least on my installation "make check" actually succeeds at
la=
> > st.
>
> If we're going to do something like that, I'd rather see it exposed as a
> more general "at most N connections" knob, where the user could choose
> N. There are plenty of other scenarios where such a restriction could
> be useful --- for instance, "make check" runs up against
> max-processes-per-user limits on a number of platforms.
>
> I would also rather that the user be forced to supply that number, to
> make certain he realizes that he's got a very low number-of-connections
> resource limit. Sweeping such problems under the rug is exactly what
> "make check" should not do.
>

Sure - I was just sharing what I did to get things working, as I have seen
reports on this from a number of people.

I should be able to generalise it fairly easily.

Something like this?

make MAX_CONNECTIONS=10 check

Maybe in the case of cygwin, where it is almost bound to fail without such
restrictions, we could put out a warning if it isn't used.

cheers

andrew

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2003-10-28 04:12:25 Re: "make check" improvement for cygwin
Previous Message Tom Lane 2003-10-28 00:41:55 Re: "make check" improvement for cygwin