Re: Fix for 8.3 MSVC locale (Was [HACKERS] NLS on MSVC strikes back!)

From: "Gevik Babakhani" <pgdev(at)xs4all(dot)nl>
To: "'Hiroshi Saito'" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>, "'Magnus Hagander'" <magnus(at)hagander(dot)net>
Cc: <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Fix for 8.3 MSVC locale (Was [HACKERS] NLS on MSVC strikes back!)
Date: 2008-02-14 20:20:12
Message-ID: 000d01c86f47$01ef72d0$0a01a8c0@gevmus
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Thank you. Is there any reason why JP locale files are not in normal
installation?

> -----Original Message-----
> From: Hiroshi Saito [mailto:z-saito(at)guitar(dot)ocn(dot)ne(dot)jp]
> Sent: Thursday, February 14, 2008 8:00 PM
> To: Magnus Hagander; Gevik Babakhani
> Cc: pgsql-patches(at)postgresql(dot)org
> Subject: Re: [PATCHES] Fix for 8.3 MSVC locale (Was [HACKERS]
> NLS on MSVC strikes back!)
>
> Hi.
>
> Sorry, I don't understand the point of this patch.
> However, reality was confirmed.
>
> I use "initdb -E UTF-8 --no-locale"
> Gevik-san patch apply it. (So, ja is not contained.)
> http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/Gevik_afterpatch.png
> Were you changeful before and after the correction?
>
> P.S)
> I was thinking about the improvement of other relations.
>
> Regards,
> Hiroshi Saito
>
> ----- Original Message -----
> From: "Magnus Hagander" <magnus(at)hagander(dot)net>
>
>
> > Gevik Babakhani wrote:
> >> Hereby a patch that fixes NLS support on PG 8.3 compiled with MSVC.
> >
> > Haven't looked into the details of the patch yet, will do
> so. But the
> > first thing I notice - you say this is only for MSVC,
> right? But the
> > patch will also change the behaviour for the mingw build.
> Since you say
> > you haven't tested on it, does the documentation imply that
> it would
> > work on mingw, or is this likely to break that build?
> Perhaps it should
> > be made conditional on MSVC only, and not on WIN32?
> >
> > //Magnus
> >
> >
> >
> > ---------------------------(end of
> broadcast)---------------------------
> > TIP 7: You can help support the PostgreSQL project by donating at
> >
> > http://www.postgresql.org/about/donate
>

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Gevik Babakhani 2008-02-14 22:24:52 Re: Fix for 8.3 MSVC locale (Was [HACKERS] NLS on MSVC strikes back!)
Previous Message Magnus Hagander 2008-02-14 19:54:01 Re: Fix for 8.3 MSVC locale (Was [HACKERS] NLS on MSVC strikes back!)