Skip site navigation (1) Skip section navigation (2)

Re: Client build of MSVC6+ patch

From: "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Andrew Dunstan" <andrew(at)dunslane(dot)net>, <mha(at)sollentuna(dot)net>,<pgsql-patches(at)postgresql(dot)org>
Subject: Re: Client build of MSVC6+ patch
Date: 2006-06-28 04:45:20
Message-ID: 000b01c69a6d$ab536580$5a0f0dde@IBMC4B5932F74B (view raw or flat)
Thread:
Lists: pgsql-patches
Hi. Tom-san.

Oops, I understood it. Thank you for suggestion.
What condition is this?

Regards,
Hiroshi Saito

From: "Tom Lane"

> "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp> writes:
>>> Why do we need to reorder the fields in the struct?
> 
>> Eh? Even my FreeBSD used well shows a structure object.
> 
> The standard lists the fields in the other order:
> http://www.opengroup.org/onlinepubs/009695399/basedefs/netdb.h.html
> 
> Even though the standard doesn't say that that has to be the physical
> order, every other platform besides Windows does it that way.  The patch
> as given is unacceptable because it *will* break other platforms (mine
> for instance ;-)).  If it has to be this way for Windows then we need
> some sort of platform-specific #ifdef.  Considering that the code works
> as-is on several sorts of Windows builds, we probably need something
> even more specific than that, like #if MSVC-before-version-XX.
> 
> regards, tom lane

Attachment: getaddrinfo_patch2
Description: application/octet-stream (721 bytes)

In response to

Responses

pgsql-patches by date

Next:From: ITAGAKI TakahiroDate: 2006-06-28 07:22:31
Subject: pgstattuple extension for indexes
Previous:From: Tom LaneDate: 2006-06-28 03:45:24
Subject: Re: Client build of MSVC6+ patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group