Skip site navigation (1) Skip section navigation (2)

Re: Re: [HACKERS] Re: Bugs: Programming Language Functions

From: "Andrew C(dot)R(dot) Martin" <a(dot)c(dot)r(dot)martin(at)reading(dot)ac(dot)uk>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: interfaces(at)postgresql(dot)org, docs(at)postgresql(dot)org, hackers(at)postgresql(dot)org
Subject: Re: Re: [HACKERS] Re: Bugs: Programming Language Functions
Date: 2000-04-13 09:31:58
Message-ID: 00041310400304.29884@sapc13.rdg.ac.uk (view raw or flat)
Thread:
Lists: pgsql-docspgsql-interfaces
On Thu, 13 Apr 2000, Andrew C.R. Martin wrote:
> On Tue, 11 Apr 2000, Tom Lane wrote:
> > "Andrew C.R. Martin" <a(dot)c(dot)r(dot)martin(at)reading(dot)ac(dot)uk> writes:
> > >> Hm.  I'm not too clear on why that would need to worry about either
> > >> TupleTableSlot or GetAttributeByName ... shouldn't it be a simple
> > >> function consuming a text Datum and producing another?
> > 
> > > Errrmmm, just following the instructions in the docs:
> > 
> > > Programmer's Manual, Chapter 4. Extensing SQL: Functins (page
> > > x414.htm), under the C examples.
> > 

Eeek! Forget my idea of #define'ing TupleTableSlot as TUPLE for backwards
compatibility. I've just realised that GetAttributeByName() now takes
a TupleTableSlot *pointer* whereas it used to take a TUPLE structure (not a
pointer).

Personally whenever I make a code change like this I try to create a new
function with the altered parameters and then make a wrapper with the old name
and calling style for backwards compatibility :-)

It seems that the .../src/tutorial/func.* examples have been updated correctly
The create_function man page however has not been updated (it even refers to
libpq-fe.h still as well as to TUPLE) and the main printable manual needs to be
updated.

Best wishes,

Andrew

--
Dr. Andrew C.R. Martin          EMail:  a(dot)c(dot)r(dot)martin(at)reading(dot)ac(dot)uk  (work)
Lecturer in Bioinformatics              andrew(at)stagleys(dot)demon(dot)co(dot)uk (home)
University of Reading
Tel.: +44 (0)118 987 5123x7022  Fax:    +44 (0)118 931 0180

In response to

pgsql-docs by date

Next:From: Vince VielhaberDate: 2000-04-13 09:41:06
Subject: Re: the Chinese version docs
Previous:From: Andrew C.R. MartinDate: 2000-04-13 07:52:05
Subject: Re: [HACKERS] Re: Bugs: Programming Language Functions

pgsql-interfaces by date

Next:From: Matthew DennyDate: 2000-04-14 09:25:23
Subject: C/C++ data types for binary query output in libpq/libpg++
Previous:From: Andrew C.R. MartinDate: 2000-04-13 07:52:05
Subject: Re: [HACKERS] Re: Bugs: Programming Language Functions

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group