Re: BUG #15910: Valgrind-detected error in DecodeTimeOnly

From: Alexander Lakhin <exclusion(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #15910: Valgrind-detected error in DecodeTimeOnly
Date: 2019-08-07 04:12:48
Message-ID: a8d43cee-aa0d-7962-8fb0-0fcfa9a422ba@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Hello Michael,
06.08.2019 9:21, Michael Paquier wrote:
> On Mon, Aug 05, 2019 at 08:55:55AM +0300, Alexander Lakhin wrote:
>> In case this bug is worth fixing, please look at the improved patch with
>> the corresponding regression test.
> In this case, DecodeSpecial() decodes the abbrevation passed down as
> UNITS, which is right on its own. Still, afterwards the code fails to
> correctly set a date from the string present. In short, your
> suggestion of fix looks good to me and that's more consistent with the
> full timezone spec case. The test case you added in this patch
> triggers the error in the code path where the timezone is not
> specified. Could you add an extra test case for the timezone
> abbreviation?
Sure, please look at the improved fix.

Best regards,
Alexander

Attachment Content-Type Size
fix-DecodeTimeOnly-v3.patch text/x-patch 2.7 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Alexander Lakhin 2019-08-07 04:29:40 Re: BUG #15910: Valgrind-detected error in DecodeTimeOnly
Previous Message Heikki Linnakangas 2019-08-06 20:29:15 Re: BUG #15939: Postgres database size is growing due to oraphan objects