| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Ash M <makmarath(at)hotmail(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #15572: Misleading message reported by "Drop function operation" on DB with functions having same name |
| Date: | 2019-02-19 17:48:04 |
| Message-ID: | CAOBaU_bzP+8nmSaidDtkVBji8hxuXKwGHxjJ7yPRCYD4r-Sovw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Tue, Feb 19, 2019 at 5:46 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Julien Rouhaud <rjuju123(at)gmail(dot)com> writes:
> >
> > Extensions calling those functions with old true/false values probably
> > won't get any warning or error during compile. Is is something we
> > should worry about or is it enough to keep the same behavior in this
> > case?
>
> Yeah, I thought about that. We can avoid such problems by assigning
> the enum values such that 0 and 1 correspond to the old behaviors.
> I didn't look to see if the proposed patch does it like that right
> now, but it should be an easy fix if not.
It does, I was just wondering whether that was a good enough solution.
Thinking more about it, I'm not sure if there's a general policy for
enums, but should we have an AssertArg() in LookupFuncName[WithArgs]
to check that a correct value was passed?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andre Piwoni | 2019-02-19 18:08:23 | Re: BUG #15638: pg_basebackup with --wal-method=stream incorrectly generates WAL segment created during backup |
| Previous Message | Andre Piwoni | 2019-02-19 17:25:57 | Re: BUG #15638: pg_basebackup with --wal-method=stream incorrectly generates WAL segment created during backup |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Fetter | 2019-02-19 18:03:03 | Re: CPU costs of random_zipfian in pgbench |
| Previous Message | Robert Haas | 2019-02-19 17:44:51 | Re: restrict pg_stat_ssl to superuser? |