| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Ash M <makmarath(at)hotmail(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #15572: Misleading message reported by "Drop function operation" on DB with functions having same name |
| Date: | 2019-02-11 02:36:17 |
| Message-ID: | CAKJS1f9bAsZVodugqwAS6kSEtrOQKOEpdeBVJALR8iEZf9kHXg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Mon, 11 Feb 2019 at 11:39, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Hmm ... I'd not looked at this before, but now that I do, the new API
> for LookupFuncName seems mighty confused, or at least confusingly
> documented. It's not clear what the combinations of the flags actually
> do, or why you'd want to use them.
>
> I wonder whether you'd be better off replacing the two bools with an
> enum, or something like that.
Okay. Here's a modified patch with the enum.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| drop_func_if_not_exists_fix_v5.patch | application/octet-stream | 25.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Bug reporting form | 2019-02-11 03:26:13 | BUG #15629: Typo in Documentation |
| Previous Message | Peter Geoghegan | 2019-02-11 00:44:39 | Re: BUG #15609: synchronous_commit=off insert performance regression with secondary indexes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Bug reporting form | 2019-02-11 03:26:13 | BUG #15629: Typo in Documentation |
| Previous Message | Tom Lane | 2019-02-11 02:10:14 | Re: indxpath.c's references to IndexOptInfo.ncolumns are all wrong, no? |