Re: BUG #16502: EXPLAIN JSON format adds extra quotes around index names

From: Euler Taveira <euler(dot)taveira(at)2ndquadrant(dot)com>
To: pgsql-bugs(at)lists(dot)postgresql(dot)org
Cc: m(dot)sakrejda(at)gmail(dot)com
Subject: Re: BUG #16502: EXPLAIN JSON format adds extra quotes around index names
Date: 2020-06-20 18:22:17
Message-ID: CAH503wCS_XAQkFtH5xFeiL52tQpYc_qRbdFt3X-e8vfUP9pMdA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Thu, 18 Jun 2020 at 16:50, PG Bug reporting form <noreply(at)postgresql(dot)org>
wrote:

>
> I ran into this in 12.3, but it looks like it's still the case in HEAD. It
> looks like this is because `explain_get_index_name` in `explain.c` always
> quotes the index name, regardless of the format being used. I'd send a
> patch, but I'm not sure how `explain_get_index_name_hook` should fit into
> this.
>
>
Indeed, relation names should return the same. The fact that
explain_get_index_name always calls quote_identifier is the culprit; it
should call quote_identifier only when the format is TEXT. Patch is
attached. I'm not sure if it should be backpatched to released versions
because there should be applications that rely on this format. However, it
would be good to backpatch it to v13 too.

--
Euler Taveira http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
0001-EXPLAIN-JSON-format-should-not-add-quotes-in-index-n.patch text/x-patch 2.6 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2020-06-20 19:06:40 Re: BUG #16502: EXPLAIN JSON format adds extra quotes around index names
Previous Message Tom Lane 2020-06-19 14:09:06 Re: BUG #16504: Wrapping query in EXISTS() causes sequential scans of tables