| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | paul(dot)vanderlinden(at)mapcreator(dot)eu, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Subject: | Re: BUG #15460: Error while creating index or constraint |
| Date: | 2018-11-13 17:50:26 |
| Message-ID: | CAH2-Wz=58+cyioF6PvUrLLCfANXsd3dzWb63Y27eXFqOwA185A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Tue, Nov 13, 2018 at 1:50 AM Thomas Munro
<thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> I think using pgoff_t would fix the problem on Windows, but on other
> systems where it maps directly to off_t it might also be 32 bits, so
> I'm not entirely sure what pgoff_t is for. Perhaps we should just use
> int64 directly for this? Like in the attached draft patch. I don't
> have a Windows system to test it on. A separate bug report that came
> in today[1] has repro steps that could be used to validate it.
I think that int64 is the way to go.
Should I fix up the diagnostic message to address Tom's complaints
about that in a separate patch?
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2018-11-13 20:12:10 | Re: BUG #15460: Error while creating index or constraint |
| Previous Message | Tomas Vondra | 2018-11-13 17:39:11 | Re: BUG #15212: Default values in partition tables don't work as expected and allow NOT NULL violation |