| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | krujkov(at)gmail(dot)com, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #15857: Parallel Hash Join makes join instead of exists |
| Date: | 2019-06-18 13:56:40 |
| Message-ID: | CA+hUKGJ0rMb0NPGSVZk0bWcLNs7otUSWgqLEOzQUhCwGEmnfDw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Wed, Jun 19, 2019 at 1:17 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> It seems a little weird to make the join-type test be the first one
> in the if() condition: it doesn't seem like the most important thing
> to test, and it doesn't agree with the way you've worded the comment.
> Otherwise +1.
Thanks for the fast review. Updated. I'll default to waiting until
after I see the tags for the release that's in progress unless you
think it should be included.
--
Thomas Munro
https://enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Prevent-Parallel-Hash-Join-for-JOIN_UNIQUE_INNER-v2.patch | application/octet-stream | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-06-18 14:05:58 | Re: BUG #15857: Parallel Hash Join makes join instead of exists |
| Previous Message | Tom Lane | 2019-06-18 13:54:45 | Re: BUG #15827: Unable to connect on Windows using pg_services.conf using Python psycopg2 |