| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | rafaelthca(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #15932: Module passwordcheck doesn't reference previous hooks |
| Date: | 2019-07-31 07:23:54 |
| Message-ID: | 97C01A5D-D814-413E-A8C8-146B17FBB63B@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
> On 31 Jul 2019, at 09:15, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Tue, Jul 30, 2019 at 11:24:20AM +0900, Michael Paquier wrote:
>> So, it would erase the trace of previous hooks if loaded last.
>> passwordcheck holds value as an example of use for some hooks, and
>> examples should be a good students, so I agree to do better and fix
>> that. The attached patch does the work, what do you think about it?
>
> Are there any objections about that stuff? I would not touch anything
> else than HEAD for that issue.
LGTM. A small nitpick is that the below comment isn’t really giving the full
picture, prev_check_password_hook is not just used for unload but for the hook
chaining.
+/* Saved hook value in case of unload */
cheers ./daniel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-07-31 07:34:01 | Re: BUG #15932: Module passwordcheck doesn't reference previous hooks |
| Previous Message | Michael Paquier | 2019-07-31 07:15:03 | Re: BUG #15932: Module passwordcheck doesn't reference previous hooks |