Re: BUG #16466: Valgrind detects an invalid read in dblink_open() with a cursor inside a transaction

From: Joe Conway <mail(at)joeconway(dot)com>
To: Alexander Lakhin <exclusion(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #16466: Valgrind detects an invalid read in dblink_open() with a cursor inside a transaction
Date: 2020-05-28 17:50:15
Message-ID: 3e6699ba-3896-a641-0c95-b64069d77a73@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 5/27/20 5:00 PM, Alexander Lakhin wrote:
> Hello Joe,
>
> 27.05.2020 22:58, Joe Conway wrote:
>> Hmmm, looks like a couple of the members of rconn are left uninitialized.
>>
>> When dblink_open() is called *without* an outer transaction it handles the
>> initialization for us, but *with* an outer transaction it does not :-(
>>
>> I think the attached fixes it.
> Yes, your patch makes valgrind silent.
> Thanks!

Thanks for checking! Pushed to all supported branches.

Joe

--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message James Lucas 2020-05-28 18:04:06 Re: Explicit deterministic COLLATE fails with pattern matching operations on column with non-deterministic collation
Previous Message Tom Lane 2020-05-28 17:31:30 Re: pgbench bug / limitation