Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, jungleboogie0(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'
Date: 2019-08-23 14:58:14
Message-ID: 29797.1566572294@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> The latest patch does that:
> + pg_log_fatal("too many jobs for this platform's select() -- try %d"
> Do you have a better suggestion to offer, like a s#jobs#-j/--jobs#?

That seems over-punctuated, plus it burdens the reader with unnecessary
detail. Most SQL folk would be confused by the reference to SELECT,
I bet. (In fact, don't we have a style guideline against mentioning
particular syscalls?)

How about just "too many jobs for this platform -- try %d" ?

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Merlin Moncure 2019-08-23 15:36:01 data modifying WITH seems to drop rows in cascading updates -- bug?
Previous Message PG Bug reporting form 2019-08-23 11:16:19 BUG #15974: Concact with || doesn't work, but function CONCAT () works