| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, James Coleman <jtc331(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #16104: Invalid DSA Memory Alloc Request in Parallel Hash |
| Date: | 2019-12-21 05:10:31 |
| Message-ID: | 29716.1576905031@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> I ran the 150MB 4096 batch "sevenb" self-join with the "rotate" patch,
> and it worked as expected. I'm now planning to commit that version,
> unless there are objections or someone wants to argue for a different
> way to spell rotate() etc.
FWIW, I do want to argue for a different way to spell that. It seems
like a mighty generic function name --- in particular, there's no
hint of the word width we're rotating in. Maybe "rotate32" would be
good enough, though I'm tempted to propose "pg_rotate32" or "rotate_bit32"
or some other variation on that.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2019-12-21 07:43:05 | Re: BUG #16104: Invalid DSA Memory Alloc Request in Parallel Hash |
| Previous Message | Thomas Munro | 2019-12-21 03:02:28 | Re: BUG #16104: Invalid DSA Memory Alloc Request in Parallel Hash |