Re: BUG #15857: Parallel Hash Join makes join instead of exists

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: krujkov(at)gmail(dot)com, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: BUG #15857: Parallel Hash Join makes join instead of exists
Date: 2019-06-18 13:17:02
Message-ID: 20972.1560863822@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> Here's a tidier version with a comment and commit message.

It seems a little weird to make the join-type test be the first one
in the if() condition: it doesn't seem like the most important thing
to test, and it doesn't agree with the way you've worded the comment.
Otherwise +1.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Joao Ferreira 2019-06-18 13:47:05 Re: Querying foreign table with SP-GiST index results in “ERROR: cache lookup failed for type 0”
Previous Message Jorge Gustavo Rocha 2019-06-18 13:13:01 Re: BUG #15827: Unable to connect on Windows using pg_services.conf using Python psycopg2