Re: BUG #16190: The usage of NULL pointer in refint.c

On Mon, Jan 06, 2020 at 03:39:36AM +0000, PG Bug reporting form wrote:
> We checked the code in file “refint.c” and there is one error occurring in
> line 636. This error is caused by the usage of pointer with NULL value. The
> code in this line is “newp->ident = strdup(ident);” The pointer “newp” is
> defined by the code in line 615 as “EPlan *newp;” and initialized by the
> code in line 628 as “newp = *eplan + i;” or in line 632 as “newp = *eplan =
> (EPlan *) malloc(sizeof(EPlan));” according to different conditions. In the
> first condition, the “*eplan” is valued by the code “*eplan = (EPlan *)
> realloc(*eplan, (i + 1) * sizeof(EPlan));” in line 627. We found the code
> hasn’t checked if the process “realloc” and “malloc” are success or not
> which directly define the value of “*eplan”. The program should check the
> effectiveness of the return value of function “realloc” and “malloc” to
> avoid this error.

It could be better to switch all that to not use directly system
calls, and rely properly on a high-level memory context with
palloc-like allocations. There could be also an argument to just
remove the module per the lack of attention it is getting, though it
is still useful as an example of use for SPI, and the docs mention
it for that.
--
Michael