Re: BUG #15804: Assertion failure when using logging_collector with EXEC_BACKEND

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Yuli Khodorkovskiy <yuli(dot)khodorkovskiy(at)crunchydata(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #15804: Assertion failure when using logging_collector with EXEC_BACKEND
Date: 2019-09-10 05:39:23
Message-ID: 20190910053923.GC11737@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Tue, Sep 10, 2019 at 01:28:51AM -0400, Tom Lane wrote:
> But the external PID file is a different story. I can believe that
> something might be expecting the sockets to be open before we create
> that file --- and since we're not using that file for an interlock,
> there's no reason to be in a hurry to create it. I think it'd make
> sense to move that step further down, so it's still done after the
> create-sockets step.

That's the actual take here. We cannot assume that nobody is relying
on that. If they do, it could be tricky to rework this logic. Moving
the external file write a bit later does not sound like a bad thing in
itself to keep more consistency with the past.
--
Michael

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2019-09-10 09:46:01 BUG #15998: query to return a table column list gives error on a missing foreign data wrapper library
Previous Message Tom Lane 2019-09-10 05:28:51 Re: BUG #15804: Assertion failure when using logging_collector with EXEC_BACKEND