| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, jungleboogie0(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE' |
| Date: | 2019-08-22 15:09:45 |
| Message-ID: | 20190822150945.3xgbvk7qqyqkyjse@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Hi,
On 2019-08-22 10:47:39 +0900, Michael Paquier wrote:
> On Wed, Aug 21, 2019 at 10:34:49AM -0400, Alvaro Herrera wrote:
> > Ah, yes, that's right -- my system's open(3p) manpage says:
> >
> > The open() function shall return a file descriptor for the named file
> > that is the lowest file descriptor not currently open for that process.
>
> Ah, well. In this case, what about that?
> ("too many jobs for this platform's select() -- try %d", i-1)
I don't think the - 1 bit is likely to be helpful, as it's too likely to
be inaccurate.
> I don't think that it is a good idea to use the option name -j/--jobs
> directly in the error string as scripts_parallel.c should not have any
> knowledge of how the option layer is in the tools using its APIs.
This isn't a particularly general API - it's in
src/bin/scripts/scripts_parallel.h. So I think a better error message is
more than worth the slight decrease in generality.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thakur, Jitender | 2019-08-22 15:23:42 | RE: PostgreSQL Not Working |
| Previous Message | Merlin Moncure | 2019-08-22 15:07:07 | Re: PostgreSQL Not Working |