| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, jungleboogie0(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE' |
| Date: | 2019-08-22 01:47:39 |
| Message-ID: | 20190822014739.GB1683@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Wed, Aug 21, 2019 at 10:34:49AM -0400, Alvaro Herrera wrote:
> Ah, yes, that's right -- my system's open(3p) manpage says:
>
> The open() function shall return a file descriptor for the named file
> that is the lowest file descriptor not currently open for that process.
Ah, well. In this case, what about that?
("too many jobs for this platform's select() -- try %d", i-1)
I don't think that it is a good idea to use the option name -j/--jobs
directly in the error string as scripts_parallel.c should not have any
knowledge of how the option layer is in the tools using its APIs.
Attached is an updated patch, with refined comments.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| parallel-slot-fdlimit-v4.patch | text/x-diff | 2.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sandeep Thakkar | 2019-08-22 06:47:46 | Re: Postgres 11.5.1 failed installation |
| Previous Message | Alvaro Herrera | 2019-08-21 14:34:49 | Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE' |