Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, jungleboogie0(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'
Date: 2019-08-21 02:40:05
Message-ID: 20190821024005.GA16883@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 2019-Aug-21, Michael Paquier wrote:

> + if (PQsocket(conn) >= FD_SETSIZE)
> + {
> + fprintf(stderr, "too many jobs for this platform's select()\n");
> + exit(1);
> + }

BTW why fprintf? Since you can get into this by careless use of -j,
ISTM that this should be a translatable string. I'd consider
pg_log_fatal(). Maybe something like "Argument of -j too large for this
platform -- try %d", numslots - i.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Christoph Ziegenberg 2019-08-21 05:11:16 Re: BUG #15967: Sequence generation using NEXTVAL() fails on 64bit systems
Previous Message Sandeep Thakkar 2019-08-21 02:29:42 Re: Postgres 11.5.1 failed installation