| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, exclusion(at)gmail(dot)com, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Subject: | Re: BUG #15668: Server crash in transformPartitionRangeBounds |
| Date: | 2019-03-06 08:27:30 |
| Message-ID: | 20190306082730.GJ30982@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Wed, Mar 06, 2019 at 04:00:42PM +0900, Amit Langote wrote:
> Thanks for looking at this. Your patch seems better, because it allows us
> to keep the error message consistent with the message one would get with
> list-partitioned syntax.
Thanks for confirming. I think that it would be nice as well to add
more test coverage for such error patterns with all the strategies.
It would be good to fix that first, so I can take care of that.
Now I don't really find the error "missing FROM-clause entry for
table" quite convincing when this is applied to a partition bound when
using a column defined in the relation. Adding more error classes in
the set of CRERR_NO_RTE would be perhaps nice, still I am not sure how
elegant it could be made when looking at expressions for partition
bounds.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Bug reporting form | 2019-03-06 15:03:50 | BUG #15671: The copy command does not load all the lines from a .csv file. |
| Previous Message | Amit Langote | 2019-03-06 07:00:42 | Re: BUG #15668: Server crash in transformPartitionRangeBounds |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chris Travers | 2019-03-06 08:33:55 | Re: Prevent extension creation in temporary schemas |
| Previous Message | Michael Paquier | 2019-03-06 07:19:00 | Re: pg_dump is broken for partition tablespaces |