| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Luis Carril <luis(dot)carril(at)swarm64(dot)com>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org>, PG Bug reporting form <noreply(at)postgresql(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Subject: | Re: BUG #15552: Unexpected error in COPY to a foreign table in a transaction |
| Date: | 2018-12-19 09:13:25 |
| Message-ID: | 20181219091325.GB680@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Wed, Dec 19, 2018 at 05:34:22PM +0900, Michael Paquier wrote:
> On Wed, Dec 19, 2018 at 04:49:19PM +0900, Etsuro Fujita wrote:
>> BTW I noticed that this error occurs not only for foreign tables but for
>> views with INSTEAD OF INSERT triggers. Here is an example on HEAD:
>>
>> To fix this I think we would also need the same treatment for the view case.
>
> Yes, this means an extra relkind check for views. Would you like to
> update the patch yourself?
While I still have that stuff in mind, for a patch on HEAD we could just
use RELKIND_CAN_HAVE_STORAGE() as additional check and also remove the
check on RELKIND_PARTITIONED_TABLE. And just add a check on
RELKIND_VIEW for back-branches on top of what's already present. If you
would like to write a new patch, please feel free to. Or I am fine to
do it myself.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Luis Carril | 2018-12-19 10:15:56 | Re: BUG #15552: Unexpected error in COPY to a foreign table in a transaction |
| Previous Message | Etsuro Fujita | 2018-12-19 09:12:12 | Re: BUG #15552: Unexpected error in COPY to a foreign table in a transaction |