Re: BUG #15402: Hot standby server with archive_mode=on keeps initial WAL segments

On Wed, Sep 26, 2018 at 03:26:50AM +0000, PG Bug reporting form wrote:
> A hot standby server with “archive_mode = on” keeps initial WAL segment
> files that copied by pg_basebackup. It shows the following status.
> 000000010000000000000042 will be kept forever in this case.

How did you find yourself in this situation? Did you take a base backup
from a primary which had .ready files in it, and those got copied to the
standby's data folder? We may want to study the possibility of
filtering things when taking a base backup instead.

> Though I understand renaming the .ready to .done manually can clean it,
> I would like to fix the server code like the following patch.
> I'd appreciate if you would consider that.

Your patch looks incorrect to me to begin with... What if archive_mode
is switched from "on" to "always" back-and-forth and there some of the
past segments which should be archived are not?
--
Michael