| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tasos Maschalidis <TaS(dot)O(dot)S(at)hotmail(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #15347: Unaccent for greek characters does not work |
| Date: | 2018-08-24 11:35:08 |
| Message-ID: | 20180824113508.GI30782@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Fri, Aug 24, 2018 at 03:32:28PM +1200, Thomas Munro wrote:
> Ok, 2 against 1. Done.
Thanks for considering it. I have not gone in details through the patch
but...
+ (codepoint.id >= ord('A') and codepoint.id <= ord('Z')) or \
+ (codepoint.id >= 0x03b1 and codepoint.id <= 0x03c9) or \
+ (codepoint.id >= 0x0391 and codepoint.id <= 0x03a9)
... If you could add notes about what those codepoints are, or just
allocate them in a variable with a proper name, that would help with the
readability. My apologies for the nits on this thread.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Bug reporting form | 2018-08-24 14:45:52 | BUG #15350: Getting invalid cache ID: 11 Errors |
| Previous Message | PG Bug reporting form | 2018-08-24 09:05:11 | BUG #15349: "make installcheck -C src/interfaces/libpq" fails |