Re: BUG #15572: Misleading message reported by "Drop function operation" on DB with functions having same name

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Ash M <makmarath(at)hotmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #15572: Misleading message reported by "Drop function operation" on DB with functions having same name
Date: 2019-01-09 00:36:06
Message-ID: 19400.1546994166@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> writes:
> Why can't we just remove the !noError check in the location where the
> error is raised?

I don't like that a bit --- the point of noError is to prevent throwing
errors, and it doesn't seem like it should be LookupFuncName's business
to decide it's smarter than its callers. Maybe we need another flag
argument?

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Andrew Dunstan 2019-01-09 00:41:55 Re: BUG #15446: Crash on ALTER TABLE
Previous Message CNG L 2019-01-08 18:47:01 Is this a bug in auto vacuum worker?

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2019-01-09 00:41:55 Re: BUG #15446: Crash on ALTER TABLE
Previous Message Amit Langote 2019-01-09 00:30:08 Re: Query with high planning time at version 11.1 compared versions 10.5 and 11.0