| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | exclusion(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #16037: Assertion fails in varbit_out |
| Date: | 2019-10-04 05:52:07 |
| Message-ID: | 18353.1570168327@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2019-10-04 01:34:48 -0400, Tom Lane wrote:
>> D'oh ... bitshiftright() needs to do the zero-pad-fixup in both
>> code paths. Will fix it tomorrow.
> Does that suggest we shouldn't make the asserts active in the branches <
> 12?
No, it just means the previous patch was an incomplete fix. The
whole point of the asserts was to flush out cases where we weren't
padding correctly, and they just did that :-)
(Besides which, we discourage people from running with asserts on
in production, so I don't quite see what your concern is.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Konstantin Knizhnik | 2019-10-04 07:28:10 | Re: Write skew anmalies are found in SERIALIZABLE isolation |
| Previous Message | Andres Freund | 2019-10-04 05:42:41 | Re: BUG #16037: Assertion fails in varbit_out |