Re: BUG #16129: Segfault in tts_virtual_materialize in logical replication worker

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Ondřej Jirman <ienieghapheoghaiwida(at)xff(dot)cz>
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #16129: Segfault in tts_virtual_materialize in logical replication worker
Date: 2019-11-22 00:45:34
Message-ID: 16189.1574383534@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

=?utf-8?Q?Ond=C5=99ej?= Jirman <ienieghapheoghaiwida(at)xff(dot)cz> writes:
> On Thu, Nov 21, 2019 at 11:08:54PM +0100, Tomas Vondra wrote:
>> 1) Print newtup.values and newtup.changed matches, so that we can check
>> it contains the tuple I shared before? There should be 8 elements in
>> each, with 'values' being values formatted as text, and 'changed' being
>> flags which values were updated.

> newtup.changed

> {true, true, false, true, true, true, true, true, false <repeats 1656 times>}

So column 3 is not getting replaced. That seems to jibe with my
theory that slot_modify_cstrings is failing to handle that case
correctly. Can you try applying the patch I posted and see if
it fixes the issue for you?

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Ondřej Jirman 2019-11-22 00:54:01 Re: BUG #16129: Segfault in tts_virtual_materialize in logical replication worker
Previous Message Ondřej Jirman 2019-11-22 00:36:26 Re: BUG #16129: Segfault in tts_virtual_materialize in logical replication worker