BUG #15838: [contrib] vacuumlo: schema variable checked for NULL three times

From: PG Bug reporting form <noreply(at)postgresql(dot)org>
To: pgsql-bugs(at)lists(dot)postgresql(dot)org
Cc: taem(at)linukz(dot)org
Subject: BUG #15838: [contrib] vacuumlo: schema variable checked for NULL three times
Date: 2019-06-07 06:15:30
Message-ID: 15838-3221652c72c5e69d@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

The following bug has been logged on the website:

Bug reference: 15838
Logged by: Timur Birsh
Email address: taem(at)linukz(dot)org
PostgreSQL version: 11.2
Operating system: CentOS 7
Description:

Hello,

vacuumlo() has this (starting on line 239):

if (!schema || !table || !field)
{
fprintf(stderr, "%s", PQerrorMessage(conn));
PQclear(res);
PQfinish(conn);
if (schema != NULL)
PQfreemem(schema);
if (schema != NULL)
PQfreemem(table);
if (schema != NULL)
PQfreemem(field);
return -1;
}

I think this can be replaced with this:

if (!schema || !table || !field)
{
fprintf(stderr, "%s", PQerrorMessage(conn));
PQclear(res);
PQfinish(conn);
if (schema != NULL) {
PQfreemem(schema);
PQfreemem(table);
PQfreemem(field);
}
return -1;
}

Thanks,
Timur

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Sasa Vilic 2019-06-07 07:22:30 Unable to create postgis extension on CentOS7 when using pg11 and newest postgis 2.5 (postgis25_11-2.5.2-2.rhel7.x86_64) due to undefined symbol OGR_GT_Flatten
Previous Message Michael Paquier 2019-06-07 05:42:33 Re: BUG #15833: defining a comment on a domain constraint fails with wrong OID