Re: BUG #15631: Generated as identity field in a temporary table with on commit drop corrupts system catalogs

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: dnsl48(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #15631: Generated as identity field in a temporary table with on commit drop corrupts system catalogs
Date: 2019-03-08 11:00:40
Message-ID: 12a993ea-1ba5-96d7-a0b5-362579fdadc1@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 2019-02-13 05:41, Michael Paquier wrote:
> The patch attached solves the problem, for consistency I would suggest
> doing the CCI even for auto dependencies.

OK, let's go with this. Attached is your patch with my comment wording.
Also a test case, but I don't suggest committing that, it's a bit too
weird. (The effect of the test is to cause catalog corruption that will
cause a later test to fail.) We can leave it in the archive for posterity.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
v2-0001-Fix-potential-catalog-corruption-with-temporary-i.patch text/plain 1.7 KB
v2-0002-XXX-Add-test-for-bug-15631.patch text/plain 1.5 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Daniel McCue 2019-03-08 14:53:55 table called 'configuration' cannot be dropped
Previous Message Amit Langote 2019-03-08 10:22:46 Re: BUG #15672: PostgreSQL 11.1/11.2 crashed after dropping a partition table