From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | starbugs(at)qq(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
Subject: | Re: BUG #16190: The usage of NULL pointer in refint.c |
Date: | 2020-01-06 06:21:35 |
Message-ID: | 1234.1578291695@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Mon, Jan 06, 2020 at 03:39:36AM +0000, PG Bug reporting form wrote:
>> We checked the code in file “refint.c” and there is one error occurring in
>> line 636.
> It could be better to switch all that to not use directly system
> calls, and rely properly on a high-level memory context with
> palloc-like allocations.
Yeah, if somebody wanted to fix this, the right way is to replace
these malloc calls with pallocs. Some investigation would be needed
about which context to use.
> ... There could be also an argument to just
> remove the module per the lack of attention it is getting, though it
> is still useful as an example of use for SPI, and the docs mention
> it for that.
The regression tests use refint too. Still, it's not production-grade
code by any means, and I'm not sure if there's much point in making
it so. I won't stand in the way if somebody else wants to ;-)
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Rui Zhong | 2020-01-06 06:39:39 | [bug report] A sql statements make query hang |
Previous Message | Tom Lane | 2020-01-06 06:06:28 | Re: BUG #16059: Tab-completion of filenames in COPY commands removes required quotes |