Re: BUG #16161: pg_ctl stop fails sometimes (on Windows)

Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> writes:
> At Thu, 19 Dec 2019 15:09:45 -0500, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote in
>> Alexander Lakhin <exclusion(at)gmail(dot)com> writes:
>>> It seems that the check for ERROR_DELETE_PENDING was added to
>>> pgwin32_safestat() blindly, the issue wasn't reproduced at that time:
>>> https://www.postgresql.org/message-id/CAB7nPqRJV6trFta-Qzgi6j2feuYR2ZC%2BKHvWdHnbpDG2scTrxw%40mail.gmail.com

>> Hmm, makes one wonder whether that's actually live code.

> Even if it is actually dead code, it seems reasonable as it stands
> since it is intending to read status of an existing file and the
> caller is assumed not to be knowing of ERROR_ACCESS_DENIED.

What I was wondering about was how come, if stat() can see the specific
error code ERROR_DELETE_PENDING, we don't get to see that from CreateFile.
The whole reason we have a problem here is that CreateFile won't return
that code :-( ... so it seems possible that the code in pgwin32_safestat
is just wrong because the case never happens.

regards, tom lane