Re: BUG #16342: CREATE TABLE LIKE INCLUDING GENERATED column order issue

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: ewaldo(at)healthetechs(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #16342: CREATE TABLE LIKE INCLUDING GENERATED column order issue
Date: 2020-04-05 15:26:36
Message-ID: 10837.1586100396@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> Confirmed. Attached is a patch to fix it. Thanks for the report!

LGTM. Perhaps extend the comment block just above, adding something
like "We must fill the attmap now so it can be used to process
GENERATED default expressions in the per-column loop."

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2020-04-05 21:08:08 BUG #16344: json_agg slow performance vs jsonb_agg, truncate table for master table with remote partition
Previous Message Peter Eisentraut 2020-04-05 11:28:20 Re: BUG #16342: CREATE TABLE LIKE INCLUDING GENERATED column order issue