Re: prokind column (was Re: [HACKERS] SQL procedures)

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: prokind column (was Re: [HACKERS] SQL procedures)
Date: 2018-03-02 22:07:58
Message-ID: b0d586ab-7111-a497-10d3-664ed7117363@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 2/28/18 17:37, Peter Eisentraut wrote:
> On 2/28/18 15:45, Tom Lane wrote:
>> I have reviewed this patch and attach an updated version below.
>> I've rebased it up to today, fixed a few minor errors, and adopted
>> most of Michael's suggestions. Also, since I remain desperately
>> unhappy with putting zeroes into prorettype, I changed it to not
>> do that ;-) ... now procedures have VOIDOID as their prorettype,
>> and it will be substantially less painful to allow them to return
>> some other scalar result in future, should we wish to. I believe
>> I've found all the places that were relying on prorettype == 0 as
>> a substitute for prokind == 'p'.
>
> I have just posted "INOUT parameters in procedures", which contains some
> of those same changes. So I think we're on the same page. I will work
> on consolidating this.

Committed this so far. More to come on touching this up.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-03-02 22:17:29 Re: [patch] BUG #15005: ANALYZE can make pg_class.reltuples inaccurate.
Previous Message Magnus Hagander 2018-03-02 22:01:45 Re: Online enabling of checksums