From 89aada5bdc9ef5c0b0125a72eb9d5494bf360282 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Fri, 15 Mar 2019 08:46:06 +0100 Subject: [PATCH v2 01/10] Initialize structure at declaration Avoids extra memset call and cast. --- contrib/dblink/dblink.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/contrib/dblink/dblink.c b/contrib/dblink/dblink.c index d95e6bfa71..d35e5ba3d8 100644 --- a/contrib/dblink/dblink.c +++ b/contrib/dblink/dblink.c @@ -982,13 +982,11 @@ materializeQueryResult(FunctionCallInfo fcinfo, { ReturnSetInfo *rsinfo = (ReturnSetInfo *) fcinfo->resultinfo; PGresult *volatile res = NULL; - volatile storeInfo sinfo; + volatile storeInfo sinfo = {0}; /* prepTuplestoreResult must have been called previously */ Assert(rsinfo->returnMode == SFRM_Materialize); - /* initialize storeInfo to empty */ - memset((void *) &sinfo, 0, sizeof(sinfo)); sinfo.fcinfo = fcinfo; PG_TRY(); base-commit: 53680c116ce8c501e4081332d32ba0e93aa1aaa2 -- 2.21.0