From 0efef3c806f132f7eb5c302b62c970bd75d4cc45 Mon Sep 17 00:00:00 2001 From: shihao zhong Date: Sat, 21 Nov 2026 12:02:43 -0500 Subject: [PATCH v4 2/2] Add planner support function to two-argument regexp_like() With no flags, regexp_like() is the same test as the ~ operator, but it had no planner support function, so it got no index condition from a pattern with a fixed prefix. Point it at textregexeq_support(), which already handles a FuncExpr. The three-argument form is left alone, since some flags make prefix extraction unsound. Discussion: https://postgr.es/m/CAGRkXqQZA-LX2UGewj9jHEmUE94U49i8XJjauDiUxZ34Tv1S-g@mail.gmail.com --- src/include/catalog/pg_proc.dat | 3 ++- src/test/regress/expected/btree_index.out | 13 +++++++++++++ src/test/regress/sql/btree_index.sql | 7 +++++++ 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a/src/include/catalog/pg_proc.dat b/src/include/catalog/pg_proc.dat index 50fb182cb79..610b8bb4fa3 100644 --- a/src/include/catalog/pg_proc.dat +++ b/src/include/catalog/pg_proc.dat @@ -3856,7 +3856,8 @@ proargnames => '{string, pattern, start, N, endoption, flags, subexpr}', prosrc => 'regexp_instr' }, { oid => '6263', descr => 'test for regexp match', - proname => 'regexp_like', prorettype => 'bool', proargtypes => 'text text', + proname => 'regexp_like', prosupport => 'textregexeq_support', + prorettype => 'bool', proargtypes => 'text text', proargnames => '{string, pattern}', prosrc => 'regexp_like_no_flags' }, { oid => '6264', descr => 'test for regexp match', proname => 'regexp_like', prorettype => 'bool', diff --git a/src/test/regress/expected/btree_index.out b/src/test/regress/expected/btree_index.out index 7c53d598649..2da97207f20 100644 --- a/src/test/regress/expected/btree_index.out +++ b/src/test/regress/expected/btree_index.out @@ -765,6 +765,19 @@ select * from btree_bpchar where f1::bpchar like 'foo%'; fool (2 rows) +-- regexp_like() should get an index condition, like the ~ operator: +create index on btree_bpchar(f1); +set enable_seqscan to false; +explain (costs off) +select * from btree_bpchar where regexp_like(f1, '^foo'); + QUERY PLAN +------------------------------------------------------------ + Index Only Scan using btree_bpchar_f1_idx1 on btree_bpchar + Index Cond: ((f1 >= 'foo'::text) AND (f1 < 'fop'::text)) + Filter: regexp_like(f1, '^foo'::text) +(3 rows) + +reset enable_seqscan; -- -- Perform unique checking, with and without the use of deduplication -- diff --git a/src/test/regress/sql/btree_index.sql b/src/test/regress/sql/btree_index.sql index 6990d7818da..6dee99fd7db 100644 --- a/src/test/regress/sql/btree_index.sql +++ b/src/test/regress/sql/btree_index.sql @@ -411,6 +411,13 @@ explain (costs off) select * from btree_bpchar where f1::bpchar like 'foo%'; select * from btree_bpchar where f1::bpchar like 'foo%'; +-- regexp_like() should get an index condition, like the ~ operator: +create index on btree_bpchar(f1); +set enable_seqscan to false; +explain (costs off) +select * from btree_bpchar where regexp_like(f1, '^foo'); +reset enable_seqscan; + -- -- Perform unique checking, with and without the use of deduplication -- -- 2.37.1 (Apple Git-137.1)