From e671f21ec10c1aac4b7be9957151c12543a0dd49 Mon Sep 17 00:00:00 2001 From: Zsolt Parragi Date: Thu, 19 Nov 2026 09:36:47 +0000 Subject: [PATCH v1] Reject non-SELECT prepared statements in EXPLAIN CREATE TABLE AS EXECUTE CREATE TABLE AS EXECUTE requires the prepared statement to be a single SELECT, and ExecuteQuery() errors out with "prepared statement is not a SELECT" otherwise. ExplainExecuteQuery() has no such check, so EXPLAIN ANALYZE CREATE TABLE ... AS EXECUTE runs a prepared INSERT, UPDATE or DELETE, creating the table only if the statement has a RETURNING list and filling it with the returned rows. A prepared SELECT INTO creates its own target table instead of the requested one. Fix by doing the same check in ExplainExecuteQuery(). Plain EXPLAIN now also reports the error, as CREATE TABLE AS EXECUTE would. Oversight in commit 9dbf2b7d75d. --- src/backend/commands/prepare.c | 8 ++++++ src/test/regress/expected/select_into.out | 32 +++++++++++++++++++++++ src/test/regress/sql/select_into.sql | 19 ++++++++++++++ 3 files changed, 59 insertions(+) diff --git a/src/backend/commands/prepare.c b/src/backend/commands/prepare.c index 876aad2100a..bddd6517e1a 100644 --- a/src/backend/commands/prepare.c +++ b/src/backend/commands/prepare.c @@ -653,6 +653,14 @@ ExplainExecuteQuery(ExecuteStmt *execstmt, IntoClause *into, ExplainState *es, plan_list = cplan->stmt_list; + /* CREATE TABLE AS EXECUTE needs a single SELECT, as in ExecuteQuery() */ + if (into && + (list_length(plan_list) != 1 || + linitial_node(PlannedStmt, plan_list)->commandType != CMD_SELECT)) + ereport(ERROR, + (errcode(ERRCODE_WRONG_OBJECT_TYPE), + errmsg("prepared statement is not a SELECT"))); + /* Explain each query */ foreach(p, plan_list) { diff --git a/src/test/regress/expected/select_into.out b/src/test/regress/expected/select_into.out index d04ca2b1bf7..ce397627db1 100644 --- a/src/test/regress/expected/select_into.out +++ b/src/test/regress/expected/select_into.out @@ -220,3 +220,35 @@ NOTICE: relation "ctas_ine_tbl" already exists, skipping (0 rows) DROP TABLE ctas_ine_tbl; +-- CREATE TABLE AS EXECUTE needs a prepared SELECT, with or without EXPLAIN +CREATE TABLE ctas_exec_src (a int); +PREPARE ctas_exec_ins AS INSERT INTO ctas_exec_src VALUES (1) RETURNING *; +PREPARE ctas_exec_into AS SELECT 1 AS a INTO ctas_exec_inner; +CREATE TABLE ctas_exec_tbl AS EXECUTE ctas_exec_ins; -- error +ERROR: prepared statement is not a SELECT +CREATE TABLE ctas_exec_tbl AS EXECUTE ctas_exec_into; -- error +ERROR: prepared statement is not a SELECT +EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF) + CREATE TABLE ctas_exec_tbl AS EXECUTE ctas_exec_ins; -- error +ERROR: prepared statement is not a SELECT +EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF) + CREATE TABLE ctas_exec_tbl AS EXECUTE ctas_exec_into; -- error +ERROR: prepared statement is not a SELECT +EXPLAIN (COSTS OFF) + CREATE TABLE ctas_exec_tbl AS EXECUTE ctas_exec_ins; -- error +ERROR: prepared statement is not a SELECT +SELECT count(*) FROM ctas_exec_src; + count +------- + 0 +(1 row) + +SELECT relname FROM pg_class + WHERE relname IN ('ctas_exec_tbl', 'ctas_exec_inner'); + relname +--------- +(0 rows) + +DEALLOCATE ctas_exec_ins; +DEALLOCATE ctas_exec_into; +DROP TABLE ctas_exec_src; diff --git a/src/test/regress/sql/select_into.sql b/src/test/regress/sql/select_into.sql index f71e3940e0a..95d237eef2f 100644 --- a/src/test/regress/sql/select_into.sql +++ b/src/test/regress/sql/select_into.sql @@ -136,3 +136,22 @@ EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF) EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF) CREATE TABLE IF NOT EXISTS ctas_ine_tbl AS EXECUTE ctas_ine_query; -- ok DROP TABLE ctas_ine_tbl; + +-- CREATE TABLE AS EXECUTE needs a prepared SELECT, with or without EXPLAIN +CREATE TABLE ctas_exec_src (a int); +PREPARE ctas_exec_ins AS INSERT INTO ctas_exec_src VALUES (1) RETURNING *; +PREPARE ctas_exec_into AS SELECT 1 AS a INTO ctas_exec_inner; +CREATE TABLE ctas_exec_tbl AS EXECUTE ctas_exec_ins; -- error +CREATE TABLE ctas_exec_tbl AS EXECUTE ctas_exec_into; -- error +EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF) + CREATE TABLE ctas_exec_tbl AS EXECUTE ctas_exec_ins; -- error +EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF) + CREATE TABLE ctas_exec_tbl AS EXECUTE ctas_exec_into; -- error +EXPLAIN (COSTS OFF) + CREATE TABLE ctas_exec_tbl AS EXECUTE ctas_exec_ins; -- error +SELECT count(*) FROM ctas_exec_src; +SELECT relname FROM pg_class + WHERE relname IN ('ctas_exec_tbl', 'ctas_exec_inner'); +DEALLOCATE ctas_exec_ins; +DEALLOCATE ctas_exec_into; +DROP TABLE ctas_exec_src; -- 2.56.0