From c29b2d6d30bb0c27e88d802b18ca6cdcffd3f29a Mon Sep 17 00:00:00 2001 From: Henson Choi Date: Tue, 17 Nov 2026 09:25:34 +0900 Subject: [PATCH v1 1/2] Add tests for length-limited JSON behavior DEFAULT casts A DEFAULT expression of a JSON behavior clause that is coerced to a length-limited RETURNING type is printed with a cast, which truncates a value that is too long when read back, where the original raised an error. The expected output shows the behavior before the fix. The next commit fixes it and updates the output. --- .../regress/expected/sqljson_queryfuncs.out | 54 +++++++++++++++++++ src/test/regress/sql/sqljson_queryfuncs.sql | 33 ++++++++++++ 2 files changed, 87 insertions(+) diff --git a/src/test/regress/expected/sqljson_queryfuncs.out b/src/test/regress/expected/sqljson_queryfuncs.out index 19db825c8ab..70f272fba81 100644 --- a/src/test/regress/expected/sqljson_queryfuncs.out +++ b/src/test/regress/expected/sqljson_queryfuncs.out @@ -1842,3 +1842,57 @@ SELECT JSON_VALUE(x, '$' RETURNING jsonb) FROM (VALUES ('1'::jsonb), (NULL), ('2 2 (3 rows) +-- Test deparsing of a DEFAULT expression that was coerced to a length-limited +-- RETURNING type. The assignment cast made by the parser raises an error for +-- a too long value, so it must not be deparsed as an explicit cast, which +-- would truncate the value instead. A cast written by the user must be kept. +CREATE VIEW queryfuncs_view_default AS +SELECT JSON_VALUE(jsonb '{}', '$.a' RETURNING varchar(3) + DEFAULT lower('ABCDEF'::text) ON EMPTY) AS r; +\sv queryfuncs_view_default; +CREATE OR REPLACE VIEW public.queryfuncs_view_default AS + SELECT JSON_VALUE('{}'::jsonb, '$."a"' RETURNING character varying(3) DEFAULT lower('ABCDEF'::text)::character varying(3) ON EMPTY) AS r +SELECT * FROM queryfuncs_view_default; +ERROR: value too long for type character varying(3) +SELECT pg_get_viewdef('queryfuncs_view_default'::regclass) AS def \gset +CREATE VIEW queryfuncs_view_default_re AS :def +SELECT * FROM queryfuncs_view_default_re; + r +----- + abc +(1 row) + +CREATE VIEW queryfuncs_view_default_cast AS +SELECT JSON_VALUE(jsonb '{}', '$.a' RETURNING varchar(3) + DEFAULT lower('ABCDEF'::text)::varchar(3) ON EMPTY) AS r; +\sv queryfuncs_view_default_cast; +CREATE OR REPLACE VIEW public.queryfuncs_view_default_cast AS + SELECT JSON_VALUE('{}'::jsonb, '$."a"' RETURNING character varying(3) DEFAULT lower('ABCDEF'::text)::character varying(3) ON EMPTY) AS r +SELECT * FROM queryfuncs_view_default_cast; + r +----- + abc +(1 row) + +-- same for a domain over a length-limited type +CREATE DOMAIN queryfuncs_d_varchar3 AS varchar(3); +CREATE VIEW queryfuncs_view_default_dom AS +SELECT JSON_VALUE(jsonb '{}', '$.a' RETURNING queryfuncs_d_varchar3 + DEFAULT lower('ABCDEF'::text) ON EMPTY) AS r; +\sv queryfuncs_view_default_dom; +CREATE OR REPLACE VIEW public.queryfuncs_view_default_dom AS + SELECT JSON_VALUE('{}'::jsonb, '$."a"' RETURNING queryfuncs_d_varchar3 DEFAULT lower('ABCDEF'::text)::queryfuncs_d_varchar3 ON EMPTY) AS r +SELECT * FROM queryfuncs_view_default_dom; +ERROR: value too long for type character varying(3) +SELECT pg_get_viewdef('queryfuncs_view_default_dom'::regclass) AS def \gset +CREATE VIEW queryfuncs_view_default_dom_re AS :def +SELECT * FROM queryfuncs_view_default_dom_re; + r +----- + abc +(1 row) + +DROP VIEW queryfuncs_view_default, queryfuncs_view_default_re, + queryfuncs_view_default_cast, queryfuncs_view_default_dom, + queryfuncs_view_default_dom_re; +DROP DOMAIN queryfuncs_d_varchar3; diff --git a/src/test/regress/sql/sqljson_queryfuncs.sql b/src/test/regress/sql/sqljson_queryfuncs.sql index 5c675d98235..25bdbee57b4 100644 --- a/src/test/regress/sql/sqljson_queryfuncs.sql +++ b/src/test/regress/sql/sqljson_queryfuncs.sql @@ -625,3 +625,36 @@ SELECT JSON_VALUE(x, '$' RETURNING json) FROM (VALUES ('1'::json), ('null'), ('2 SELECT JSON_VALUE(x, '$.a' RETURNING jsonb) FROM (VALUES ('{"a": 1}'::jsonb), ('{}'), ('{"a": 2}')) v(x); SELECT JSON_VALUE(x, 'strict $.a' RETURNING jsonb) FROM (VALUES ('{"a": 1}'::jsonb), ('[]'), ('{"a": 2}')) v(x); SELECT JSON_VALUE(x, '$' RETURNING jsonb) FROM (VALUES ('1'::jsonb), (NULL), ('2')) v(x); + +-- Test deparsing of a DEFAULT expression that was coerced to a length-limited +-- RETURNING type. The assignment cast made by the parser raises an error for +-- a too long value, so it must not be deparsed as an explicit cast, which +-- would truncate the value instead. A cast written by the user must be kept. +CREATE VIEW queryfuncs_view_default AS +SELECT JSON_VALUE(jsonb '{}', '$.a' RETURNING varchar(3) + DEFAULT lower('ABCDEF'::text) ON EMPTY) AS r; +\sv queryfuncs_view_default; +SELECT * FROM queryfuncs_view_default; +SELECT pg_get_viewdef('queryfuncs_view_default'::regclass) AS def \gset +CREATE VIEW queryfuncs_view_default_re AS :def +SELECT * FROM queryfuncs_view_default_re; +CREATE VIEW queryfuncs_view_default_cast AS +SELECT JSON_VALUE(jsonb '{}', '$.a' RETURNING varchar(3) + DEFAULT lower('ABCDEF'::text)::varchar(3) ON EMPTY) AS r; +\sv queryfuncs_view_default_cast; +SELECT * FROM queryfuncs_view_default_cast; +-- same for a domain over a length-limited type +CREATE DOMAIN queryfuncs_d_varchar3 AS varchar(3); +CREATE VIEW queryfuncs_view_default_dom AS +SELECT JSON_VALUE(jsonb '{}', '$.a' RETURNING queryfuncs_d_varchar3 + DEFAULT lower('ABCDEF'::text) ON EMPTY) AS r; +\sv queryfuncs_view_default_dom; +SELECT * FROM queryfuncs_view_default_dom; +SELECT pg_get_viewdef('queryfuncs_view_default_dom'::regclass) AS def \gset +CREATE VIEW queryfuncs_view_default_dom_re AS :def +SELECT * FROM queryfuncs_view_default_dom_re; + +DROP VIEW queryfuncs_view_default, queryfuncs_view_default_re, + queryfuncs_view_default_cast, queryfuncs_view_default_dom, + queryfuncs_view_default_dom_re; +DROP DOMAIN queryfuncs_d_varchar3; -- 2.54.0 (Apple Git-157)