From 0c8445d42310d957ac368678f4e5cc6559f9091c Mon Sep 17 00:00:00 2001 From: Henson Choi Date: Thu, 22 Oct 2026 12:45:47 +0900 Subject: [PATCH v1 1/2] Add tests for JSON_TABLE and XMLTABLE alias lists The column alias list of a JSON_TABLE or XMLTABLE is not printed, and neither is the alias of one that is renamed to avoid another one in an outer query level, so the text refers to names that are not defined: SELECT p, q FROM JSON_TABLE(...) t SELECT a, (SELECT max(json_table_1.b) AS max FROM JSON_TABLE(...)) AS m FROM JSON_TABLE(...) The expected output shows the behavior before the fix. The next commit fixes it and updates the output. --- .../regress/expected/sqljson_jsontable.out | 65 +++++++++++++++++++ src/test/regress/expected/xml.out | 24 +++++++ src/test/regress/sql/sqljson_jsontable.sql | 24 +++++++ src/test/regress/sql/xml.sql | 15 +++++ 4 files changed, 128 insertions(+) diff --git a/src/test/regress/expected/sqljson_jsontable.out b/src/test/regress/expected/sqljson_jsontable.out index 1dcb9479de3..650150c6ac0 100644 --- a/src/test/regress/expected/sqljson_jsontable.out +++ b/src/test/regress/expected/sqljson_jsontable.out @@ -2049,3 +2049,68 @@ SELECT * FROM JSON_TABLE(jsonb '{}', '$' PASSING ROW(1, 2) < ROW(3, 4) AS x t (1 row) +-- Test JSON_TABLE() column alias list deparsing, and the alias of a +-- JSON_TABLE() that is renamed to avoid a conflict with another one in an +-- outer query level +CREATE VIEW json_table_view_alias AS +SELECT t.p, t.q +FROM JSON_TABLE(jsonb '[{"a": 1, "b": 2}]', '$[*]' + COLUMNS (a int PATH '$.a', b int PATH '$.b')) AS t(p, q); +\sv json_table_view_alias; +CREATE OR REPLACE VIEW public.json_table_view_alias AS + SELECT p, + q + FROM JSON_TABLE( + '[{"a": 1, "b": 2}]'::jsonb, '$[*]' AS json_table_path_0 + COLUMNS ( + a integer PATH '$."a"', + b integer PATH '$."b"' + ) + ) t +CREATE VIEW json_table_view_conflict AS +SELECT a, (SELECT max(b) FROM JSON_TABLE(jsonb '[{"b": 2}]', '$[*]' + COLUMNS (b int PATH '$.b'))) AS m +FROM JSON_TABLE(jsonb '[{"a": 1}]', '$[*]' COLUMNS (a int PATH '$.a')); +\sv json_table_view_conflict; +CREATE OR REPLACE VIEW public.json_table_view_conflict AS + SELECT a, + ( SELECT max(json_table_1.b) AS max + FROM JSON_TABLE( + '[{"b": 2}]'::jsonb, '$[*]' AS json_table_path_0 + COLUMNS ( + b integer PATH '$."b"' + ) + )) AS m + FROM JSON_TABLE( + '[{"a": 1}]'::jsonb, '$[*]' AS json_table_path_0 + COLUMNS ( + a integer PATH '$."a"' + ) + ) +-- NATURAL JOIN matches the columns by the names in the alias lists +CREATE VIEW json_table_view_natural AS +SELECT x, y +FROM JSON_TABLE(jsonb '[{"a": 1, "b": 2}]', '$[*]' + COLUMNS (a int PATH '$.a', b int PATH '$.b')) t1(x, y) +NATURAL JOIN JSON_TABLE(jsonb '[{"a": 2, "b": 1}]', '$[*]' + COLUMNS (a int PATH '$.a', b int PATH '$.b')) t2(y, x); +\sv json_table_view_natural; +CREATE OR REPLACE VIEW public.json_table_view_natural AS + SELECT t1.x, + t1.y + FROM JSON_TABLE( + '[{"a": 1, "b": 2}]'::jsonb, '$[*]' AS json_table_path_0 + COLUMNS ( + a integer PATH '$."a"', + b integer PATH '$."b"' + ) + ) t1 + JOIN JSON_TABLE( + '[{"a": 2, "b": 1}]'::jsonb, '$[*]' AS json_table_path_0 + COLUMNS ( + a integer PATH '$."a"', + b integer PATH '$."b"' + ) + ) t2 USING (x, y) +DROP VIEW json_table_view_alias, json_table_view_conflict, + json_table_view_natural; diff --git a/src/test/regress/expected/xml.out b/src/test/regress/expected/xml.out index 6998745ee03..15a63493482 100644 --- a/src/test/regress/expected/xml.out +++ b/src/test/regress/expected/xml.out @@ -1933,3 +1933,27 @@ SELECT xmltext('x'|| '

73

'::xml || .42 || true || 'j'::char); x<P>73</P>0.42truej (1 row) +-- Test XMLTABLE() column alias list deparsing, and the alias of an +-- XMLTABLE() that is renamed to avoid a conflict with another one in an +-- outer query level +CREATE VIEW xmltableview_alias AS +SELECT t.p +FROM xmldata, XMLTABLE('/ROWS/ROW' PASSING data + COLUMNS a int PATH '@id') AS t(p); +\sv xmltableview_alias +CREATE OR REPLACE VIEW public.xmltableview_alias AS + SELECT t.p + FROM xmldata, + LATERAL XMLTABLE(('/ROWS/ROW'::text) PASSING (xmldata.data) COLUMNS a integer PATH ('@id'::text)) t +CREATE VIEW xmltableview_conflict AS +SELECT a, (SELECT max(b) FROM XMLTABLE('/ROWS/ROW' PASSING data + COLUMNS b int PATH '@id')) AS m +FROM xmldata, XMLTABLE('/ROWS/ROW' PASSING data COLUMNS a int PATH '@id'); +\sv xmltableview_conflict +CREATE OR REPLACE VIEW public.xmltableview_conflict AS + SELECT "xmltable".a, + ( SELECT max(xmltable_1.b) AS max + FROM XMLTABLE(('/ROWS/ROW'::text) PASSING (xmldata.data) COLUMNS b integer PATH ('@id'::text))) AS m + FROM xmldata, + LATERAL XMLTABLE(('/ROWS/ROW'::text) PASSING (xmldata.data) COLUMNS a integer PATH ('@id'::text)) +DROP VIEW xmltableview_alias, xmltableview_conflict; diff --git a/src/test/regress/sql/sqljson_jsontable.sql b/src/test/regress/sql/sqljson_jsontable.sql index 73e60411df6..4e5f33a6196 100644 --- a/src/test/regress/sql/sqljson_jsontable.sql +++ b/src/test/regress/sql/sqljson_jsontable.sql @@ -1117,3 +1117,27 @@ SELECT * FROM JSON_TABLE(jsonb '{}', '$' PASSING 'a' < 'b' COLLATE "C" AS x COLUMNS (a bool PATH '$x')); SELECT * FROM JSON_TABLE(jsonb '{}', '$' PASSING ROW(1, 2) < ROW(3, 4) AS x COLUMNS (a bool PATH '$x')); + +-- Test JSON_TABLE() column alias list deparsing, and the alias of a +-- JSON_TABLE() that is renamed to avoid a conflict with another one in an +-- outer query level +CREATE VIEW json_table_view_alias AS +SELECT t.p, t.q +FROM JSON_TABLE(jsonb '[{"a": 1, "b": 2}]', '$[*]' + COLUMNS (a int PATH '$.a', b int PATH '$.b')) AS t(p, q); +\sv json_table_view_alias; +CREATE VIEW json_table_view_conflict AS +SELECT a, (SELECT max(b) FROM JSON_TABLE(jsonb '[{"b": 2}]', '$[*]' + COLUMNS (b int PATH '$.b'))) AS m +FROM JSON_TABLE(jsonb '[{"a": 1}]', '$[*]' COLUMNS (a int PATH '$.a')); +\sv json_table_view_conflict; +-- NATURAL JOIN matches the columns by the names in the alias lists +CREATE VIEW json_table_view_natural AS +SELECT x, y +FROM JSON_TABLE(jsonb '[{"a": 1, "b": 2}]', '$[*]' + COLUMNS (a int PATH '$.a', b int PATH '$.b')) t1(x, y) +NATURAL JOIN JSON_TABLE(jsonb '[{"a": 2, "b": 1}]', '$[*]' + COLUMNS (a int PATH '$.a', b int PATH '$.b')) t2(y, x); +\sv json_table_view_natural; +DROP VIEW json_table_view_alias, json_table_view_conflict, + json_table_view_natural; diff --git a/src/test/regress/sql/xml.sql b/src/test/regress/sql/xml.sql index 0581d21b03f..438bb2f980e 100644 --- a/src/test/regress/sql/xml.sql +++ b/src/test/regress/sql/xml.sql @@ -724,3 +724,18 @@ SELECT xmltext(' '); SELECT xmltext('foo `$_-+?=*^%!|/\()[]{}'); SELECT xmltext('foo & <"bar">'); SELECT xmltext('x'|| '

73

'::xml || .42 || true || 'j'::char); + +-- Test XMLTABLE() column alias list deparsing, and the alias of an +-- XMLTABLE() that is renamed to avoid a conflict with another one in an +-- outer query level +CREATE VIEW xmltableview_alias AS +SELECT t.p +FROM xmldata, XMLTABLE('/ROWS/ROW' PASSING data + COLUMNS a int PATH '@id') AS t(p); +\sv xmltableview_alias +CREATE VIEW xmltableview_conflict AS +SELECT a, (SELECT max(b) FROM XMLTABLE('/ROWS/ROW' PASSING data + COLUMNS b int PATH '@id')) AS m +FROM xmldata, XMLTABLE('/ROWS/ROW' PASSING data COLUMNS a int PATH '@id'); +\sv xmltableview_conflict +DROP VIEW xmltableview_alias, xmltableview_conflict; -- 2.54.0 (Apple Git-157)