From 917972001c47014c57f7310451d4a7c7c4239fad Mon Sep 17 00:00:00 2001 From: Henson Choi Date: Thu, 22 Oct 2026 12:45:47 +0900 Subject: [PATCH v1 1/2] Add tests for XMLTABLE alias lists The column alias list of an XMLTABLE is not printed, and neither is the alias of one that is renamed to avoid another one in an outer query level, so the text refers to names that are not defined: SELECT t.p FROM xmldata, LATERAL XMLTABLE(...) t SELECT "xmltable".a, (SELECT max(xmltable_1.b) AS max FROM XMLTABLE(...)) AS m FROM xmldata, LATERAL XMLTABLE(...) The expected output shows the behavior before the fix. The next commit fixes it and updates the output. --- src/test/regress/expected/xml.out | 24 ++++++++++++++++++++++++ src/test/regress/sql/xml.sql | 15 +++++++++++++++ 2 files changed, 39 insertions(+) diff --git a/src/test/regress/expected/xml.out b/src/test/regress/expected/xml.out index ac90e3eccc8..384ea02dda8 100644 --- a/src/test/regress/expected/xml.out +++ b/src/test/regress/expected/xml.out @@ -1813,3 +1813,27 @@ SELECT * FROM XMLTABLE('.' PASSING XMLELEMENT(NAME a) columns a varchar(20) PATH | <foo/> (1 row) +-- Test XMLTABLE() column alias list deparsing, and the alias of an +-- XMLTABLE() that is renamed to avoid a conflict with another one in an +-- outer query level +CREATE VIEW xmltableview_alias AS +SELECT t.p +FROM xmldata, XMLTABLE('/ROWS/ROW' PASSING data + COLUMNS a int PATH '@id') AS t(p); +\sv xmltableview_alias +CREATE OR REPLACE VIEW public.xmltableview_alias AS + SELECT t.p + FROM xmldata, + LATERAL XMLTABLE(('/ROWS/ROW'::text) PASSING (xmldata.data) COLUMNS a integer PATH ('@id'::text)) t +CREATE VIEW xmltableview_conflict AS +SELECT a, (SELECT max(b) FROM XMLTABLE('/ROWS/ROW' PASSING data + COLUMNS b int PATH '@id')) AS m +FROM xmldata, XMLTABLE('/ROWS/ROW' PASSING data COLUMNS a int PATH '@id'); +\sv xmltableview_conflict +CREATE OR REPLACE VIEW public.xmltableview_conflict AS + SELECT "xmltable".a, + ( SELECT max(xmltable_1.b) AS max + FROM XMLTABLE(('/ROWS/ROW'::text) PASSING (xmldata.data) COLUMNS b integer PATH ('@id'::text))) AS m + FROM xmldata, + LATERAL XMLTABLE(('/ROWS/ROW'::text) PASSING (xmldata.data) COLUMNS a integer PATH ('@id'::text)) +DROP VIEW xmltableview_alias, xmltableview_conflict; diff --git a/src/test/regress/sql/xml.sql b/src/test/regress/sql/xml.sql index 81628227e0d..8a506b5e693 100644 --- a/src/test/regress/sql/xml.sql +++ b/src/test/regress/sql/xml.sql @@ -677,3 +677,18 @@ SELECT * FROM XMLTABLE('*' PASSING 'pre"', b xml PATH '""'); + +-- Test XMLTABLE() column alias list deparsing, and the alias of an +-- XMLTABLE() that is renamed to avoid a conflict with another one in an +-- outer query level +CREATE VIEW xmltableview_alias AS +SELECT t.p +FROM xmldata, XMLTABLE('/ROWS/ROW' PASSING data + COLUMNS a int PATH '@id') AS t(p); +\sv xmltableview_alias +CREATE VIEW xmltableview_conflict AS +SELECT a, (SELECT max(b) FROM XMLTABLE('/ROWS/ROW' PASSING data + COLUMNS b int PATH '@id')) AS m +FROM xmldata, XMLTABLE('/ROWS/ROW' PASSING data COLUMNS a int PATH '@id'); +\sv xmltableview_conflict +DROP VIEW xmltableview_alias, xmltableview_conflict; -- 2.54.0 (Apple Git-157)