From cf24e69946701b133344441d14d7bde09762859b Mon Sep 17 00:00:00 2001 From: "Chao Li (Evan)" Date: Thu, 29 Oct 2026 12:06:57 +0800 Subject: [PATCH v1] Remove unused is_redo argument from pgstat_execute_transactional_drops() The argument was introduced by 8b1dccd37c7 as part of the transactional statistics scaffolding, but remained unused when 5891c7a8ed8 implemented the actual deletion. Remove it from the function and its callers, since statistics deletion does not distinguish WAL replay from normal prepared-transaction completion. Author: Chao Li --- src/backend/access/transam/twophase.c | 4 ++-- src/backend/access/transam/xact.c | 4 ++-- src/backend/utils/activity/pgstat_xact.c | 2 +- src/include/pgstat.h | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/backend/access/transam/twophase.c b/src/backend/access/transam/twophase.c index 48a83501ee9..58b01654918 100644 --- a/src/backend/access/transam/twophase.c +++ b/src/backend/access/transam/twophase.c @@ -1627,9 +1627,9 @@ FinishPreparedTransaction(const char *gid, bool isCommit) DropRelationFiles(delrels, ndelrels, false); if (isCommit) - pgstat_execute_transactional_drops(hdr->ncommitstats, commitstats, false); + pgstat_execute_transactional_drops(hdr->ncommitstats, commitstats); else - pgstat_execute_transactional_drops(hdr->nabortstats, abortstats, false); + pgstat_execute_transactional_drops(hdr->nabortstats, abortstats); /* * Handle cache invalidation messages. diff --git a/src/backend/access/transam/xact.c b/src/backend/access/transam/xact.c index 0121a0c8fa0..49e64939667 100644 --- a/src/backend/access/transam/xact.c +++ b/src/backend/access/transam/xact.c @@ -6330,7 +6330,7 @@ xact_redo_commit(xl_xact_parsed_commit *parsed, /* see equivalent call for relations above */ XLogFlush(lsn); - pgstat_execute_transactional_drops(parsed->nstats, parsed->stats, true); + pgstat_execute_transactional_drops(parsed->nstats, parsed->stats); } /* @@ -6441,7 +6441,7 @@ xact_redo_abort(xl_xact_parsed_abort *parsed, TransactionId xid, /* see equivalent call for relations above */ XLogFlush(lsn); - pgstat_execute_transactional_drops(parsed->nstats, parsed->stats, true); + pgstat_execute_transactional_drops(parsed->nstats, parsed->stats); } } diff --git a/src/backend/utils/activity/pgstat_xact.c b/src/backend/utils/activity/pgstat_xact.c index 820cf97de87..466742f8467 100644 --- a/src/backend/utils/activity/pgstat_xact.c +++ b/src/backend/utils/activity/pgstat_xact.c @@ -310,7 +310,7 @@ pgstat_get_transactional_drops(bool isCommit, xl_xact_stats_item **items) * during normal 2PC COMMIT/ABORT PREPARED processing. */ void -pgstat_execute_transactional_drops(int ndrops, struct xl_xact_stats_item *items, bool is_redo) +pgstat_execute_transactional_drops(int ndrops, struct xl_xact_stats_item *items) { int not_freed_count = 0; diff --git a/src/include/pgstat.h b/src/include/pgstat.h index 187d82c96fe..9b99062f853 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -937,7 +937,7 @@ extern void AtPrepare_PgStat(void); extern void PostPrepare_PgStat(void); struct xl_xact_stats_item; extern int pgstat_get_transactional_drops(bool isCommit, struct xl_xact_stats_item **items); -extern void pgstat_execute_transactional_drops(int ndrops, struct xl_xact_stats_item *items, bool is_redo); +extern void pgstat_execute_transactional_drops(int ndrops, struct xl_xact_stats_item *items); /* -- 2.50.1 (Apple Git-155)