From 53c15fe76343f5fcac0c7b139f32f2a6ac110451 Mon Sep 17 00:00:00 2001 From: Fujii Masao Date: Thu, 22 Oct 2026 21:53:06 +0900 Subject: [PATCH v2 2/2] Remove the redundant interface list and fix function headings in predicate.c The interface list duplicates declarations in the headers and has accumulated stale signatures and missing entries. Remove it rather than maintaining a separate copy of the declarations. Also correct the headings above AtPrepare_PredicateLocks() and PostPrepare_PredicateLocks(), which incorrectly name the separate AtPrepare_Locks() and PostPrepare_Locks() functions. --- src/backend/storage/lmgr/predicate.c | 44 ++-------------------------- 1 file changed, 2 insertions(+), 42 deletions(-) diff --git a/src/backend/storage/lmgr/predicate.c b/src/backend/storage/lmgr/predicate.c index b888823f312..fc038dc9ab4 100644 --- a/src/backend/storage/lmgr/predicate.c +++ b/src/backend/storage/lmgr/predicate.c @@ -149,46 +149,6 @@ * *------------------------------------------------------------------------- */ -/* - * INTERFACE ROUTINES - * - * predicate lock reporting - * GetPredicateLockStatusData(void) - * - * predicate lock maintenance - * GetSerializableTransactionSnapshot(Snapshot snapshot) - * SetSerializableTransactionSnapshot(Snapshot snapshot, - * VirtualTransactionId *sourcevxid) - * RegisterPredicateLockingXid(void) - * PredicateLockRelation(Relation relation, Snapshot snapshot) - * PredicateLockPage(Relation relation, BlockNumber blkno, - * Snapshot snapshot) - * PredicateLockTID(Relation relation, const ItemPointerData *tid, Snapshot snapshot, - * TransactionId tuple_xid) - * PredicateLockPageSplit(Relation relation, BlockNumber oldblkno, - * BlockNumber newblkno) - * PredicateLockPageCombine(Relation relation, BlockNumber oldblkno, - * BlockNumber newblkno) - * TransferPredicateLocksToHeapRelation(Relation relation) - * ReleasePredicateLocks(bool isCommit, bool isReadOnlySafe) - * - * conflict detection (may also trigger rollback) - * CheckForSerializableConflictOut(Relation relation, TransactionId xid, - * Snapshot snapshot) - * CheckForSerializableConflictIn(Relation relation, const ItemPointerData *tid, - * BlockNumber blkno) - * CheckTableForSerializableConflictIn(Relation relation) - * - * final rollback checking - * PreCommit_CheckForSerializationFailure(void) - * - * two-phase commit support - * AtPrepare_PredicateLocks(void); - * PostPrepare_PredicateLocks(TransactionId xid); - * PredicateLockTwoPhaseFinish(FullTransactionId fxid, bool isCommit); - * predicatelock_twophase_recover(FullTransactionId fxid, uint16 info, - * void *recdata, uint32 len); - */ #include "postgres.h" @@ -4671,7 +4631,7 @@ PreCommit_CheckForSerializationFailure(void) */ /* - * AtPrepare_Locks + * AtPrepare_PredicateLocks * Do the preparatory work for a PREPARE: make 2PC state file * records for all predicate locks currently held. */ @@ -4738,7 +4698,7 @@ AtPrepare_PredicateLocks(void) } /* - * PostPrepare_Locks + * PostPrepare_PredicateLocks * Clean up after successful PREPARE. Unlike the non-predicate * lock manager, we do not need to transfer locks to a dummy * PGPROC because our SERIALIZABLEXACT will stay around -- 2.56.0