From 604e1d42388e1f4be917985dbde2242c6f3858db Mon Sep 17 00:00:00 2001 From: Jim Jones Date: Sun, 18 Oct 2026 14:09:33 +0200 Subject: [PATCH v1 3/4] pgstattuple: Reject unlogged relations during recovery Unlogged tables and indexes have no data on a standby, so reading one there must fail. pgstattuple(), pgstattuple_approx(), pg_relpages(), pgstatindex(), pgstatginindex() and pgstathashindex() read the relation directly instead of going through the planner, so on a standby they failed with a confusing low-level message instead of the error that SELECT reports: ERROR: could not open file "base/5/16384": No such file or directory Check for this case and report the same error as SELECT: ERROR: cannot access temporary or unlogged relations during recovery Author: Jim Jones Reported-by: Zsolt Parragi --- contrib/pgstattuple/pgstatapprox.c | 7 +++++++ contrib/pgstattuple/pgstatindex.c | 25 +++++++++++++++++++++++++ contrib/pgstattuple/pgstattuple.c | 7 +++++++ 3 files changed, 39 insertions(+) diff --git a/contrib/pgstattuple/pgstatapprox.c b/contrib/pgstattuple/pgstatapprox.c index 21e0b50fb4b..38b0cc951e2 100644 --- a/contrib/pgstattuple/pgstatapprox.c +++ b/contrib/pgstattuple/pgstatapprox.c @@ -16,6 +16,7 @@ #include "access/htup_details.h" #include "access/relation.h" #include "access/visibilitymap.h" +#include "access/xlog.h" #include "catalog/pg_am_d.h" #include "commands/vacuum.h" #include "funcapi.h" @@ -332,6 +333,12 @@ pgstattuple_approx_internal(Oid relid, FunctionCallInfo fcinfo) (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("cannot access temporary tables of other sessions"))); + /* Temporary and unlogged relations are inaccessible during recovery. */ + if (!RelationIsPermanent(rel) && RecoveryInProgress()) + ereport(ERROR, + (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), + errmsg("cannot access temporary or unlogged relations during recovery"))); + /* * We support only relation kinds with a visibility map and a free space * map. diff --git a/contrib/pgstattuple/pgstatindex.c b/contrib/pgstattuple/pgstatindex.c index 8951ad0aac4..87e79527361 100644 --- a/contrib/pgstattuple/pgstatindex.c +++ b/contrib/pgstattuple/pgstatindex.c @@ -32,6 +32,7 @@ #include "access/htup_details.h" #include "access/nbtree.h" #include "access/relation.h" +#include "access/xlog.h" #include "catalog/namespace.h" #include "catalog/pg_am.h" #include "funcapi.h" @@ -238,6 +239,12 @@ pgstatindex_impl(Relation rel, FunctionCallInfo fcinfo) (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("cannot access temporary tables of other sessions"))); + /* Temporary and unlogged relations are inaccessible during recovery. */ + if (!RelationIsPermanent(rel) && RecoveryInProgress()) + ereport(ERROR, + (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), + errmsg("cannot access temporary or unlogged relations during recovery"))); + /* * A !indisready index could lead to ERRCODE_DATA_CORRUPTED later, so exit * early. We're capable of assessing an indisready&&!indisvalid index, @@ -482,6 +489,12 @@ pg_relpages_impl(Relation rel) RelationGetRelationName(rel)), errdetail_relkind_not_supported(rel->rd_rel->relkind))); + /* Temporary and unlogged relations are inaccessible during recovery. */ + if (!RelationIsPermanent(rel) && RecoveryInProgress()) + ereport(ERROR, + (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), + errmsg("cannot access temporary or unlogged relations during recovery"))); + /* note: this will work OK on non-local temp tables */ relpages = RelationGetNumberOfBlocks(rel); @@ -557,6 +570,12 @@ pgstatginindex_internal(Oid relid, FunctionCallInfo fcinfo) (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("cannot access temporary indexes of other sessions"))); + /* Temporary and unlogged relations are inaccessible during recovery. */ + if (!RelationIsPermanent(rel) && RecoveryInProgress()) + ereport(ERROR, + (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), + errmsg("cannot access temporary or unlogged relations during recovery"))); + /* see pgstatindex_impl */ if (!rel->rd_index->indisvalid) ereport(ERROR, @@ -647,6 +666,12 @@ pgstathashindex(PG_FUNCTION_ARGS) (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("cannot access temporary indexes of other sessions"))); + /* Temporary and unlogged relations are inaccessible during recovery. */ + if (!RelationIsPermanent(rel) && RecoveryInProgress()) + ereport(ERROR, + (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), + errmsg("cannot access temporary or unlogged relations during recovery"))); + /* see pgstatindex_impl */ if (!rel->rd_index->indisvalid) ereport(ERROR, diff --git a/contrib/pgstattuple/pgstattuple.c b/contrib/pgstattuple/pgstattuple.c index 6a7f8cb4a7c..f9495390673 100644 --- a/contrib/pgstattuple/pgstattuple.c +++ b/contrib/pgstattuple/pgstattuple.c @@ -30,6 +30,7 @@ #include "access/nbtree.h" #include "access/relscan.h" #include "access/tableam.h" +#include "access/xlog.h" #include "catalog/namespace.h" #include "catalog/pg_am_d.h" #include "funcapi.h" @@ -254,6 +255,12 @@ pgstat_relation(Relation rel, FunctionCallInfo fcinfo) (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("cannot access temporary tables of other sessions"))); + /* Temporary and unlogged relations are inaccessible during recovery. */ + if (!RelationIsPermanent(rel) && RecoveryInProgress()) + ereport(ERROR, + (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), + errmsg("cannot access temporary or unlogged relations during recovery"))); + if (RELKIND_HAS_TABLE_AM(rel->rd_rel->relkind) || rel->rd_rel->relkind == RELKIND_SEQUENCE) { -- 2.56.0