From 76a2db073dbb39d48500bd900cc377855e7d4daf Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson Date: Sat, 5 Sep 2026 20:20:45 +0200 Subject: [PATCH v1 1/5] Fix enum value visibility for data_checksums When the data_checksums GUC was changed into an enum the enum values were all incorrectly marked as hidden, which made pg_settings report an empty array. Fix by setting all as visible as they should be. Found by Noah using AI assisted review with GPT. Backpatch to v19 where the GUC was changed in the online checksums feature. Reported-by: Noah Misch Discussion: https://postgr.es/m/... Backpatch-through: 19 --- src/backend/utils/misc/guc_tables.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/utils/misc/guc_tables.c b/src/backend/utils/misc/guc_tables.c index c6d9b2a6f89..342aaeef59a 100644 --- a/src/backend/utils/misc/guc_tables.c +++ b/src/backend/utils/misc/guc_tables.c @@ -513,10 +513,10 @@ static const struct config_enum_entry file_extend_method_options[] = { }; static const struct config_enum_entry data_checksums_options[] = { - {"on", PG_DATA_CHECKSUM_VERSION, true}, - {"off", PG_DATA_CHECKSUM_OFF, true}, - {"inprogress-on", PG_DATA_CHECKSUM_INPROGRESS_ON, true}, - {"inprogress-off", PG_DATA_CHECKSUM_INPROGRESS_OFF, true}, + {"on", PG_DATA_CHECKSUM_VERSION, false}, + {"off", PG_DATA_CHECKSUM_OFF, false}, + {"inprogress-on", PG_DATA_CHECKSUM_INPROGRESS_ON, false}, + {"inprogress-off", PG_DATA_CHECKSUM_INPROGRESS_OFF, false}, {NULL, 0, false} }; -- 2.39.3 (Apple Git-146)