From a56270a832812fbd9255c1da5cef1324216308f3 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Fri, 28 Aug 2026 23:06:46 +0200 Subject: [PATCH v2 1/6] Remove unused global variable [xlog.c] src/backend/access/transam/xlog.c:675:19: error: variable 'LocalMinRecoveryPointTLI' set but not used [-Werror,-Wunused-but-set-global] This was apparently never used (initial commit 70e81861fad). Discussion: https://www.postgresql.org/message-id/flat/eb013f9d-2247-444e-8815-9d17b4ce78e7%40eisentraut.org --- src/backend/access/transam/xlog.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index 3203f2fd4ee..b98fe621964 100644 --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access/transam/xlog.c @@ -672,7 +672,6 @@ static TimeLineID openLogTLI = 0; * Those values are kept consistent as long as crash recovery runs. */ static XLogRecPtr LocalMinRecoveryPoint; -static TimeLineID LocalMinRecoveryPointTLI; static bool updateMinRecoveryPoint = true; /* @@ -2752,7 +2751,6 @@ UpdateMinRecoveryPoint(XLogRecPtr lsn, bool force) /* update local copy */ LocalMinRecoveryPoint = ControlFile->minRecoveryPoint; - LocalMinRecoveryPointTLI = ControlFile->minRecoveryPointTLI; if (!XLogRecPtrIsValid(LocalMinRecoveryPoint)) updateMinRecoveryPoint = false; @@ -2787,7 +2785,6 @@ UpdateMinRecoveryPoint(XLogRecPtr lsn, bool force) ControlFile->minRecoveryPointTLI = newMinRecoveryPointTLI; UpdateControlFile(); LocalMinRecoveryPoint = newMinRecoveryPoint; - LocalMinRecoveryPointTLI = newMinRecoveryPointTLI; ereport(DEBUG2, errmsg_internal("updated min recovery point to %X/%08X on timeline %u", @@ -3201,7 +3198,6 @@ XLogNeedsFlush(XLogRecPtr record) if (!LWLockConditionalAcquire(ControlFileLock, LW_SHARED)) return true; LocalMinRecoveryPoint = ControlFile->minRecoveryPoint; - LocalMinRecoveryPointTLI = ControlFile->minRecoveryPointTLI; LWLockRelease(ControlFileLock); /* @@ -6207,12 +6203,10 @@ StartupXLOG(void) if (InArchiveRecovery) { LocalMinRecoveryPoint = ControlFile->minRecoveryPoint; - LocalMinRecoveryPointTLI = ControlFile->minRecoveryPointTLI; } else { LocalMinRecoveryPoint = InvalidXLogRecPtr; - LocalMinRecoveryPointTLI = 0; } /* Check that the GUCs used to generate the WAL allow recovery */ @@ -6749,7 +6743,6 @@ SwitchIntoArchiveRecovery(XLogRecPtr EndRecPtr, TimeLineID replayTLI) } /* update local copy */ LocalMinRecoveryPoint = ControlFile->minRecoveryPoint; - LocalMinRecoveryPointTLI = ControlFile->minRecoveryPointTLI; /* * The startup process can update its local copy of minRecoveryPoint from @@ -8316,7 +8309,6 @@ CreateRestartPoint(int flags) /* update local copy */ LocalMinRecoveryPoint = ControlFile->minRecoveryPoint; - LocalMinRecoveryPointTLI = ControlFile->minRecoveryPointTLI; } if (flags & CHECKPOINT_IS_SHUTDOWN) ControlFile->state = DB_SHUTDOWNED_IN_RECOVERY; @@ -9161,7 +9153,6 @@ xlog_redo(XLogReaderState *record) if (InArchiveRecovery) { LocalMinRecoveryPoint = ControlFile->minRecoveryPoint; - LocalMinRecoveryPointTLI = ControlFile->minRecoveryPointTLI; } if (XLogRecPtrIsValid(LocalMinRecoveryPoint) && LocalMinRecoveryPoint < lsn) { @@ -9307,7 +9298,6 @@ xlog2_redo(XLogReaderState *record) if (InArchiveRecovery) { LocalMinRecoveryPoint = ControlFile->minRecoveryPoint; - LocalMinRecoveryPointTLI = ControlFile->minRecoveryPointTLI; } if (XLogRecPtrIsValid(LocalMinRecoveryPoint) && LocalMinRecoveryPoint < lsn) { -- 2.55.0