From 8af9e75a43a06ea56199ae7418aba15086eb4e29 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Tue, 18 Aug 2026 10:52:24 +0200 Subject: [PATCH 07/11] Fix some -Wcast-qual warnings [guc_funcs] Some rearrangements to avoid having to cast away const qualifiers. --- src/backend/utils/misc/guc_funcs.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/backend/utils/misc/guc_funcs.c b/src/backend/utils/misc/guc_funcs.c index e2c2919484e..defaa796a0c 100644 --- a/src/backend/utils/misc/guc_funcs.c +++ b/src/backend/utils/misc/guc_funcs.c @@ -971,6 +971,7 @@ show_all_settings(PG_FUNCTION_ARGS) while (call_cntr < max_calls) /* do when there is more left to send */ { struct config_generic *conf = guc_vars[call_cntr]; + const char *cvalues[NUM_PG_SETTINGS_ATTS]; char *values[NUM_PG_SETTINGS_ATTS]; HeapTuple tuple; Datum result; @@ -984,7 +985,14 @@ show_all_settings(PG_FUNCTION_ARGS) } /* extract values for the current variable */ - GetConfigOptionValues(conf, (const char **) values); + GetConfigOptionValues(conf, cvalues); + + /* + * This is so that both GetConfigOptionValues() and + * BuildTupleFromCStrings() are satisfied about the const-ness without + * triggering warnings. + */ + memcpy(values, cvalues, sizeof(cvalues)); /* build a tuple */ tuple = BuildTupleFromCStrings(attinmeta, values); -- 2.55.0